avm2: Implement XML.setName (ruffle-rs#12979)

* avm2/tests: Implement XML.setName; add a test

* avm2: Basic support for QNames in XML.setName (no namespace support yet)

* avm2: Reorder order of Attribute/Element/PI checks in XML.setName

* avm2: Throw error ruffle-rs#1117 when the name passed to XML.setName is not a valid XML name

core/src/avm2/e4x.rs

@@ -777,6 +777,10 @@ impl<'gc> E4XNode<'gc> {
         self.0.read().namespace
     }
 
+    pub fn set_local_name(&self, name: AvmString<'gc>, mc: &Mutation<'gc>) {
+        self.0.write(mc).local_name = Some(name);
+    }
+
     pub fn local_name(&self) -> Option<AvmString<'gc>> {
         self.0.read().local_name
     }

core/src/avm2/globals/XML.as

@@ -59,6 +59,7 @@ package {
         AS3 native function hasComplexContent():Boolean;
         AS3 native function hasSimpleContent():Boolean;
         AS3 native function name():Object;
+        AS3 native function setName(name:*):void;
         AS3 native function namespace(prefix:String = null):*;
         AS3 native function localName():Object;
         AS3 native function toXMLString():String;

core/src/avm2/globals/xml.rs

@@ -81,6 +81,53 @@ pub fn name<'gc>(
     }
 }
 
+pub fn set_name<'gc>(
+    activation: &mut Activation<'_, 'gc>,
+    this: Object<'gc>,
+    args: &[Value<'gc>],
+) -> Result<Value<'gc>, Error<'gc>> {
+    let xml = this.as_xml_object().unwrap();
+    let node = xml.node();
+
+    let is_attribute_or_element = matches!(
+        &*node.kind(),
+        E4XNodeKind::Attribute(_)
+            | E4XNodeKind::ProcessingInstruction(_)
+            | E4XNodeKind::Element { .. }
+    );
+
+    if !is_attribute_or_element {
+        return Ok(Value::Undefined);
+    }
+
+    let new_name = args.get_value(0);
+
+    let new_name = if let Some(qname) = new_name.as_object().and_then(|q| q.as_qname_object()) {
+        let has_no_ns = qname.name().is_any_namespace()
+            || (qname.name().namespace_set().len() == 1
+                && qname.name().namespace_set()[0].is_public());
+        if !has_no_ns {
+            avm2_stub_method!(activation, "XML", "setName", "with QName namespaces");
+        }
+        qname.local_name()
+    } else {
+        new_name.coerce_to_string(activation)?
+    };
+
+    let is_name_valid = crate::avm2::e4x::is_xml_name(activation, new_name.into())?;
+    if !is_name_valid {
+        return Err(Error::AvmError(type_error(
+            activation,
+            &format!("Error #1117: Invalid XML name: {}.", new_name),
+            1117,
+        )?));
+    }
+
+    node.set_local_name(new_name, activation.context.gc_context);
+
+    Ok(Value::Undefined)
+}
+
 pub fn namespace<'gc>(
     activation: &mut Activation<'_, 'gc>,
     _this: Object<'gc>,

tests/tests/swfs/avm2/xml_set_name/Test.as

@@ -0,0 +1,23 @@
+package {
+    import flash.display.MovieClip;
+
+    public class Test extends MovieClip {
+        public function Test() {
+            var a:XML = <outer attrib="value"><inner>innerText</inner></outer>;
+            var b:XML = new XML("justText");
+            trace(a.toXMLString());
+            a.setName("newOuterName");
+            trace(a.toXMLString());
+            a.setName(new QName(null,"someOuterName"));
+            trace(a.toXMLString());
+            a.setName(new QName("","otherOuterName"));
+            trace(a.toXMLString());
+            a.@attrib.setName("newattribname");
+            trace(a.toXMLString());
+            trace(b.toXMLString());
+            b.setName("noeffect");
+            trace(b.toXMLString());
+        }
+    }
+}
+

tests/tests/swfs/avm2/xml_set_name/output.txt

@@ -0,0 +1,17 @@
+<outer attrib="value">
+  <inner>innerText</inner>
+</outer>
+<newOuterName attrib="value">
+  <inner>innerText</inner>
+</newOuterName>
+<someOuterName attrib="value">
+  <inner>innerText</inner>
+</someOuterName>
+<otherOuterName attrib="value">
+  <inner>innerText</inner>
+</otherOuterName>
+<otherOuterName newattribname="value">
+  <inner>innerText</inner>
+</otherOuterName>
+justText
+justText

tests/tests/swfs/avm2/xml_set_name/test.toml

@@ -0,0 +1 @@
+num_frames = 1

tests/tests/swfs/from_avmplus/e4x/XML/e13_4_4_37/test.toml

@@ -1,2 +1 @@
 num_ticks = 1
-known_failure = true

tests/tests/swfs/from_avmplus/e4x/XMLList/e13_5_4_19/test.toml

@@ -1,2 +1 @@
 num_ticks = 1
-known_failure = true