Skip to content

Commit

Permalink
windeployqt: Remove special handling of virtual keyboard plugin
Browse files Browse the repository at this point in the history
virtualkeyboard is a qt module and thus covered by the "no-<module"
switch. The special handling is no longer needed with the more dynamic
approach of handling Qt modules.

Pick-to: 6.5
Change-Id: Ice6e30261e60b484669748411e019764bbdeaa55
Reviewed-by: Yuhang Zhao <[email protected]>
Reviewed-by: Timothée Keller <[email protected]>
Reviewed-by: Joerg Bornemann <[email protected]>
  • Loading branch information
owolff committed Apr 12, 2023
1 parent 75995d8 commit f8a3489
Showing 1 changed file with 0 additions and 18 deletions.
18 changes: 0 additions & 18 deletions src/tools/windeployqt/main.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -79,10 +79,6 @@ static void assignKnownModuleIds()
#undef DECLARE_KNOWN_MODULE
#undef DEFINE_KNOWN_MODULE

enum QtPlugin {
QtVirtualKeyboardPlugin = 0x1
};

static const char webEngineProcessC[] = "QtWebEngineProcess";

static inline QString webProcessBinary(const char *binaryName, Platform p)
Expand Down Expand Up @@ -420,10 +416,6 @@ static inline int parseArguments(const QStringList &arguments, QCommandLineParse
QStringLiteral("Deploy compiler runtime (Desktop only)."));
parser->addOption(compilerRunTimeOption);

QCommandLineOption noVirtualKeyboardOption(QStringLiteral("no-virtualkeyboard"),
QStringLiteral("Disable deployment of the Virtual Keyboard."));
parser->addOption(noVirtualKeyboardOption);

QCommandLineOption noCompilerRunTimeOption(QStringLiteral("no-compiler-runtime"),
QStringLiteral("Do not deploy compiler runtime (Desktop only)."));
parser->addOption(noCompilerRunTimeOption);
Expand Down Expand Up @@ -506,8 +498,6 @@ static inline int parseArguments(const QStringList &arguments, QCommandLineParse
return CommandLineParseError;
}

if (parser->isSet(noVirtualKeyboardOption))
options->disabledPlugins |= QtVirtualKeyboardPlugin;

if (parser->isSet(releaseWithDebugInfoOption))
std::wcerr << "Warning: " << releaseWithDebugInfoOption.names().first() << " is obsolete.";
Expand Down Expand Up @@ -838,12 +828,6 @@ static QString deployPlugin(const QString &plugin, const QDir &subDir,
const QString &libraryLocation, const QString &infix,
Platform platform)
{
// Filter out disabled plugins
if ((disabledPlugins & QtVirtualKeyboardPlugin)
&& plugin.startsWith("qtvirtualkeyboardplugin"_L1)) {
return {};
}

const QString pluginPath = subDir.absoluteFilePath(plugin);
// Deploy QUiTools plugins as is without further dependency checking.
// The user needs to ensure all required libraries are present (would
Expand Down Expand Up @@ -914,8 +898,6 @@ QStringList findQtPlugins(ModuleBitset *usedQtModules, const ModuleBitset &disab
: debugMatchModeIn;
QDir subDir(subDirFi.absoluteFilePath());
// Filter out disabled plugins
if ((disabledPlugins & QtVirtualKeyboardPlugin) && subDirName == "virtualkeyboard"_L1)
continue;
if (disabledQtModules.test(QtQmlToolingModuleId) && subDirName == "qmltooling"_L1)
continue;
// Filter for platform or any.
Expand Down

0 comments on commit f8a3489

Please sign in to comment.