Quote all string values to reduce probability of compose syntax errors #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before:
```
...
services:
<service>:
....
logging:
options:
tag: {{.ImageName}}|{{.Name}}|{{.ImageFullID}}|{{.FullID}}
max-file: 3
...
```
and docker-compose up fails
after:
```
...
services:
<service>:
....
logging:
options:
tag: "{{.ImageName}}|{{.Name}}|{{.ImageFullID}}|{{.FullID}}"
max-file: "3"
...
```
and docker-compose up works
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there,
thank you for your work with docker-autocompose!
I encountered some problems when recreating containers when using custom log configs.
In our case we set the log-options as follows:
The current master of the script would remove the quotes around tag and max-file, which would make docker-compose interpret these options as malformed dict and integer, both syntax violations.
The proposed solution would quote all values that are strings.
I'm glad to improve my contribution if you have any comments.