Merge pull request #2164 from Hyperkid123/missing-spec-id

fix(config-utils): add ID to required list of direct nav items
RedHatInsights · Jan 30, 2025 · 1ddc43f · 1ddc43f
2 parents 988f8f1 + 0588a25
commit 1ddc43f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/packages/config-utils/src/feo/spec/frontend-crd.schema.json b/packages/config-utils/src/feo/spec/frontend-crd.schema.json
@@ -231,6 +231,7 @@
         }
       },
       "required": [
+        "id",
         "title"
       ],
       "additionalProperties": false

diff --git a/packages/config-utils/src/feo/validate-frontend-crd.test.ts b/packages/config-utils/src/feo/validate-frontend-crd.test.ts
@@ -55,13 +55,15 @@ describe('Validate FrontEnd CRD', () => {
     const mixedNavItem = {
       title: 'A mixed nav item',
       href: '/foo/bar',
+      id: 'test-id',
       segmentRef: {
         segmentId: 'test-segment',
         frontendName: 'test-frontend',
       },
     };
     const validDirectNavItem = {
       title: 'A valid nav item',
+      id: 'valid-id',
       href: '/foo/bar',
     };
     const validNavSegment = {
-Original file line number
+Diff line change
@@ Expand Up / @@ -231,6 +231,7 @@ @@
             }
           },
           "required": [
+            "id",
             "title"
           ],
           "additionalProperties": false
@@ Expand Down @@