Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/make dismiss action #5

Merged
merged 9 commits into from
Mar 13, 2020
Merged

Feature/make dismiss action #5

merged 9 commits into from
Mar 13, 2020

Conversation

ReeceM
Copy link
Owner

@ReeceM ReeceM commented Mar 13, 2020

This adds the ability to dismiss notifications once they have been shown.

It will close #4 feature request.

Functionality provided is:

Dismiss notification for session by means of using the init() options

{
   dismissible: true,
}

that will make it dismissible for the session, it will come back when page is reloaded.

The other way to dismiss the action for a time is the following:

{
   dismissible: true,
   dismissFor: new Date('2020-03-14T00:00:00'), // must be date object.
}

the date is stored in localStorage and then compared with the current time to determine if the rest of the http requests and rendering should run.

@ReeceM ReeceM added the enhancement New feature or request label Mar 13, 2020
@ReeceM ReeceM added this to the v1.0.0 Release milestone Mar 13, 2020
@ReeceM ReeceM merged commit 4d29ed4 into develop Mar 13, 2020
@ReeceM ReeceM deleted the feature/make-dismiss-action branch May 26, 2020 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant