Visual Studio 16.10 Updates

[RehanSaeed]

Fixes #48.

dotnet_style_parentheses_in_other_operators

We got some better documentation from .NET about this setting which makes it clear that we should change our configuration from a suggestion of using always_for_clarity to a warning to use never_if_unnecessary:

// dotnet_style_parentheses_in_other_operators = always_for_clarity
var v = (a.b).Length;

// dotnet_style_parentheses_in_other_operators = never_if_unnecessary
var v = a.b.Length;

The second example seems more desirable.

dotnet_style_operator_placement_when_wrapping

Realized that this setting was missing the error level, so set it to warning.

csharp_style_prefer_null_check_over_type_check

Enabled this setting to prefer is not null over is object. Set to warning level. See dotnet/roslyn#55005.

// csharp_style_prefer_null_check_over_type_check = false
foo is object
// csharp_style_prefer_null_check_over_type_check = true
foo is not null

dotnet_style_namespace_match_folder

Enabled this setting so that namespaces must match folders. Set at suggestion level as sometimes devs want to also use logical folders to group content instead of representing hard folders. This is particularly useful when a namespace contains a large amount of content. See dotnet/roslyn#49990.

I've also polled the community for their thoughts on the defaults here https://twitter.com/RehanSaeedUK/status/1424724592082493440.

[T-0pel]

Hi, I have tested out the dotnet_style_namespace_match_folder setting and it seems to run into issues with files that are placed directly in the project. It seems to want to add a '.' at the end of the namespace:

[RehanSaeed]

Yes, it seems there is an open issue about this in the roslyn repo. I expect it to get fixed very soon (probably with the .NET 6 release). Since this is set to suggestion level, I don't plan to make changes to the .editorconfig.