Skip to content

Commit

Permalink
Fix createdump on alpine (dotnet/coreclr#24623)
Browse files Browse the repository at this point in the history
  • Loading branch information
mikem8361 authored May 18, 2019
1 parent 30a188d commit d927e22
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions src/coreclr/src/debug/createdump/crashinfo.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -198,12 +198,14 @@ CrashInfo::GatherCrashInfo(MINIDUMP_TYPE minidumpType)
}
}
}
// Add all the heap (read/write) memory regions (m_otherMappings contains the heaps)
// Add all the heap read/write memory regions (m_otherMappings contains the heaps). On Alpine
// the heap regions are marked RWX instead of just RW.
else if (minidumpType & MiniDumpWithPrivateReadWriteMemory)
{
for (const MemoryRegion& region : m_otherMappings)
{
if (region.Permissions() == (PF_R | PF_W))
uint32_t permissions = region.Permissions();
if (permissions == (PF_R | PF_W) || permissions == (PF_R | PF_W | PF_X))
{
InsertMemoryBackedRegion(region);
}
Expand Down

0 comments on commit d927e22

Please sign in to comment.