Remove #![allow(dead_code)] from forc along with dead code (FuelL…

…abs#1176)

* Remove `#![allow(dead_code)]` from `forc` along with dead code

This was originally required in order to support the separate implicit
`bin` and `lib` targets for `forc` without getting loads of warnings,
but as of FuelLabs#1174 `cargo` is aware of the separate targets and this is no
longer necessary.

* Remove old feature-gated start_fuel_core re-export

forc/src/cli/commands/addr2line.rs

@@ -79,7 +79,7 @@ pub(crate) fn exec(command: Command) -> Result<()> {
 
 struct ReadRange {
     source: String,
-    source_start_byte: usize,
+    _source_start_byte: usize,
     source_start_line: usize,
     offset: usize,
     length: usize,
@@ -117,7 +117,7 @@ fn read_range<P: AsRef<Path>>(
     let source = context_buffer.make_contiguous().join("");
     let length = range.end - range.start;
 
-    let (source_start_line, source_start_byte, offset) = start_pos.ok_or_else(|| {
+    let (source_start_line, _source_start_byte, offset) = start_pos.ok_or_else(|| {
         io::Error::new(
             io::ErrorKind::UnexpectedEof,
             "Source file was modified, and the mapping is now out of range",
@@ -133,7 +133,7 @@ fn read_range<P: AsRef<Path>>(
 
     Ok(ReadRange {
         source,
-        source_start_byte,
+        _source_start_byte,
         source_start_line,
         offset,
         length,

forc/src/lib.rs

@@ -1,4 +1,3 @@
-#![allow(dead_code)]
 pub mod cli;
 mod ops;
 mod utils;
@@ -11,6 +10,5 @@ pub mod test {
 
 #[cfg(feature = "util")]
 pub mod util {
-    pub use crate::utils::client::start_fuel_core;
     pub use sway_utils::constants;
 }

forc/src/ops/forc_explorer.rs

@@ -12,7 +12,6 @@ type DownloadResult<T> = std::result::Result<T, Box<dyn std::error::Error + Send
 
 #[derive(Deserialize, Debug)]
 struct GitHubRelease {
-    url: String,
     assets: Vec<GitHubReleaseAsset>,
     name: String,
 }

forc/src/ops/forc_init.rs

@@ -24,6 +24,8 @@ enum FileType {
     Dir,
 }
 
+// Dead fields required for deserialization.
+#[allow(dead_code)]
 #[derive(serde::Deserialize, Debug)]
 struct Links {
     git: String,
@@ -32,6 +34,8 @@ struct Links {
     cur: String,
 }
 
+// Dead fields required for deserialization.
+#[allow(dead_code)]
 #[derive(serde::Deserialize, Debug)]
 struct ContentResponse {
     #[serde(rename = "_links")]

forc/src/utils/mod.rs

@@ -1,4 +1,3 @@
-pub mod client;
 pub mod defaults;
 pub mod parameters;