Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(widgets): 💡 use variant_color in the class of Slider #673

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

M-Adoo
Copy link
Collaborator

@M-Adoo M-Adoo commented Dec 17, 2024

Purpose of this Pull Request

Please briefly describe what this Pull Request is aiming to achieve.

Checklist Before Merging

Please ensure the following are completed before merging:

  • If this is linked to an issue, include the link in your description.
  • If you've made changes to the code or documentation, make sure these are updated in the CHANGELOG.md file.
  • If you've introduced any break changes, briefly describe them in the Breaking section of the CHANGELOG.md file.

Additional Information

The bot will replace #pr in CHANGELOG.md with your pull request number. If your branch is out of sync, use git pull --rebase to update it.

If you're unsure about which branch to submit your Pull Request to, or when it will be released after being merged, please refer to our Release Guide.

If you're working on a widget and need help writing test cases, we have some macros that can assist you. Please refer to the Ribir Dev Helper documentation.

@M-Adoo M-Adoo enabled auto-merge December 17, 2024 07:18
@M-Adoo M-Adoo disabled auto-merge December 17, 2024 07:21
@M-Adoo M-Adoo force-pushed the refactor/slider-cls-variant-color branch from 2df2f6d to 99ac4a4 Compare December 17, 2024 07:48
@M-Adoo M-Adoo added the B-test Notify bot to start testing label Dec 17, 2024
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.64%. Comparing base (a7d939d) to head (99ac4a4).
Report is 48 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #673      +/-   ##
==========================================
- Coverage   83.93%   83.64%   -0.29%     
==========================================
  Files         200      209       +9     
  Lines       26350    28449    +2099     
==========================================
+ Hits        22116    23796    +1680     
- Misses       4234     4653     +419     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wjian23 wjian23 added this pull request to the merge queue Dec 18, 2024
Merged via the queue into RibirX:master with commit 09b5781 Dec 18, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B-test Notify bot to start testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants