Skip to content

Commit

Permalink
raise default "max_connections" value to 100
Browse files Browse the repository at this point in the history
Documentation says the limit is 5, but it was really 10 (at least
since 2004).  But since MPD wants to promote using many small clients
idling around, and these clients consume only very few resources, it
seems reasonable to raise this limit's default value.
  • Loading branch information
MaxKellermann committed Mar 19, 2020
1 parent 82743df commit 56c234b
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions NEWS
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ ver 0.21.21 (not yet released)
- gme: ignore empty tags
* output
- solaris: port to NetBSD
* raise default "max_connections" value to 100

ver 0.21.20 (2020/02/16)
* decoder
Expand Down
2 changes: 1 addition & 1 deletion doc/user.rst
Original file line number Diff line number Diff line change
Expand Up @@ -695,7 +695,7 @@ These settings are various limitations to prevent :program:`MPD` from using too
* - **connection_timeout SECONDS**
- If a client does not send any new data in this time period, the connection is closed. Clients waiting in "idle" mode are excluded from this. Default is 60.
* - **max_connections NUMBER**
- This specifies the maximum number of clients that can be connected to :program:`MPD` at the same time. Default is 5.
- This specifies the maximum number of clients that can be connected to :program:`MPD` at the same time. Default is 100.
* - **max_playlist_length NUMBER**
- The maximum number of songs that can be in the playlist. Default is 16384.
* - **max_command_list_size KBYTES**
Expand Down
2 changes: 1 addition & 1 deletion src/Main.cxx
Original file line number Diff line number Diff line change
Expand Up @@ -460,7 +460,7 @@ MainOrThrow(int argc, char *argv[])
#endif

const unsigned max_clients =
raw_config.GetPositive(ConfigOption::MAX_CONN, 10);
raw_config.GetPositive(ConfigOption::MAX_CONN, 100);
instance->client_list = new ClientList(max_clients);

initialize_decoder_and_player(raw_config, config.replay_gain);
Expand Down

0 comments on commit 56c234b

Please sign in to comment.