Skip to content

Commit

Permalink
android/build.py: drop -lmstackrealign
Browse files Browse the repository at this point in the history
This flag doesn't appear to work, and since we never had a problem
without the flag, implementing Google's recommendation is useless.
  • Loading branch information
MaxKellermann committed Jan 12, 2020
1 parent ab41c16 commit b470003
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions android/build.py
Original file line number Diff line number Diff line change
Expand Up @@ -117,10 +117,6 @@ def __init__(self, tarball_path, src_path, build_path,
self.ldflags = common_flags
self.libs = ''

# required flags from https://android.googlesource.com/platform/ndk/+/ndk-release-r20/docs/BuildSystemMaintainers.md#additional-required-arguments
if ndk_arch == 'x86' and int(android_api_level) < 24:
self.ldflags += ' -lmstackrealign'

self.is_arm = ndk_arch == 'arm'
self.is_armv7 = self.is_arm and 'armv7' in self.cflags
self.is_aarch64 = ndk_arch == 'arm64'
Expand Down

0 comments on commit b470003

Please sign in to comment.