Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.0.0 beta #60

Merged
merged 44 commits into from
Jan 8, 2021
Merged

4.0.0 beta #60

merged 44 commits into from
Jan 8, 2021

Conversation

RobDWaller
Copy link
Owner

  • Fixed Namespacing.
  • Improved types and doc types.
  • Tidied up and got integration tests working.
  • Got CI Pipeline working with PHP 7.4 and 8.0
  • Bumped PHPStan strictness from 7 to 8.
  • Created separate Unit and Integration test suites.
  • Got benchmark tests working.

@RobDWaller
Fixed namespacing by adding Unit in test files in tests/Unit directory.
392e1c9
@RobDWaller
Fixed return type issues in ParseTest file.
4e09aa8
@RobDWaller
Fixed return type and mock / stub issues in BuildTest file.
963ecf0
@RobDWaller
Renamed EndToEnd integration tests file to BuildParse as this is more…
9381e27 
… descriptive.
@RobDWaller
Tidied up namespacing in BuildParse integrations tests.
ffd5a78
@RobDWaller
Got most of the BuildParse integration tests working.
0f6838a
@RobDWaller
Removed commented code from BuildParse integration tests.
665383d
@RobDWaller
Used commented code from BuildParse integration tests to create worki…
8ce5236 
…ng integration tests in BuildValidateTest class.
@RobDWaller
Applied PSR 12 lint code fixes to new integration tests.
39ceede
@RobDWaller
Tidied up types and doc types in Validate class.
3e618a3
@RobDWaller
Fixed types and type docs in Build class.
e99c99e
@RobDWaller
Amend to wrong doc type in Build class comments.
e64a9f9
@RobDWaller
Updated the Build reset method to return a fresh instance of the Buil…
da738c7 
…d class instead of unsetting properties.
@RobDWaller
Fixed doc type issues in Token and Tokens class.
a4ff322
@RobDWaller
Applied type and doc type fixes to Encoders and Decoders.
a6a0a22
@RobDWaller
Added types and doc types to Signature interface.
266d36d
@RobDWaller
Added types and doc types to Parse class.
d736804
@RobDWaller
Bumped PHPStan strictness level to 8.
b20a4d5
@RobDWaller
Applied PSR-12 lint fixes after types and doctype fixes.
f8d380a
@RobDWaller
Added php md doc annotation to suppress specific short variable on cr…
5e76028 
…eateBasicToken method in tokens class.
@RobDWaller
Defined seperate unit and integration test suites in PHP Unit config …
43e568c 
…and can them separtely in CI pipeline.
@RobDWaller
Fixed Benchmark tests so they work and applied PHPStan checks to benc…
df2fc17 
…hmarks directory.
@RobDWaller
Updated Infection PHP mutation tests to only run against unit test su…
bfa56ca 
…ite.
@RobDWaller
Fixed code coverage issues in Build class.
1a13f59
@RobDWaller
Fixed PSR-12 code lint issues in BuildTests file.
cd2ac64
@RobDWaller
Tidied up and added further mocking to ParsedTest class.
24299d1
@RobDWaller
Removed Errors trait as no longer needed due to improvements in valid…
d376df1 
…ation handling.
@RobDWaller
Moved JsonEncoder Test into Helper directory to reflect src directory…
177df36 
… structure.
@RobDWaller
Dropped Mutation Score Index check to 93 as this is about as high as …
10272b8 
…it can be got currently.
@RobDWaller
Bumped PHPUnit version to 9.5 in composer config.
02acf58
@codecov
Copy link

codecov bot commented Jan 2, 2021 •
edited
Loading

Codecov Report

Merging #60 (dd32f58) into 4.0.0 (a036105) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##               4.0.0       #60   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       111       124   +13     
===========================================
  Files             10        14    +4     
  Lines            288       345   +57     
===========================================
+ Hits             288       345   +57
Impacted Files Coverage Δ Complexity Δ
src/Helper/JsonEncoder.php 100.00% <ø> (ø) 2.00 <0.00> (ø)
src/Jwt.php 100.00% <ø> (ø) 3.00 <0.00> (ø)
src/Parsed.php 100.00% <ø> (ø) 19.00 <0.00> (ø)
src/Secret.php 100.00% <ø> (ø) 2.00 <0.00> (ø)
src/Build.php 100.00% <100.00%> (ø) 22.00 <17.00> (ø)
src/Decoders/DecodeHs256.php 100.00% <100.00%> (ø) 2.00 <2.00> (?)
src/Encoders/EncodeHs256.php 100.00% <100.00%> (ø) 6.00 <6.00> (?)
src/Helper/Base64.php 100.00% <100.00%> (ø) 4.00 <4.00> (?)
src/Helper/Validator.php 100.00% <100.00%> (ø) 7.00 <7.00> (?)
src/Parse.php 100.00% <100.00%> (ø) 18.00 <14.00> (-10.00)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96b1deb...dd32f58. Read the comment docs.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 6, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@RobDWaller RobDWaller marked this pull request as ready for review January 6, 2021 10:57
@RobDWaller
Copy link
Owner Author

TODO: Add BuildValidate Benchmark Test

@RobDWaller
Copy link
Owner Author

TODO: Tokens integration tests.

@RobDWaller RobDWaller merged commit bfb8f96 into 4.0.0 Jan 8, 2021
@RobDWaller RobDWaller deleted the 4.0.0-beta branch February 1, 2021 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@RobDWaller