Add spec test for port defaults for Postgres and MySQL

RobertLowe · Apr 1, 2019 · a94f3bc · a94f3bc
1 parent 08aef10
commit a94f3bc
Showing 1 changed file with 15 additions and 1 deletion.
diff --git a/test/metabase/db/spec_test.clj b/test/metabase/db/spec_test.clj
@@ -30,7 +30,7 @@
   (assoc (default-pg-spec "") :dbname nil, :somethingrandom nil)
   (db.spec/postgres
    {:host    "localhost"
-    :port            5432
+    :port            nil
     :dbname          nil
     :db              nil
     :somethingrandom nil}))
@@ -39,3 +39,17 @@
 (expect
   (default-pg-spec "")
   (db.spec/postgres {}))
+
+(defn- default-mysql-spec [db]
+  {:classname                     "org.mariadb.jdbc.Driver"
+   :subprotocol                   "mysql"
+   :subname                       (format "//localhost:3306/%s" db)})
+
+;; Check that we default to port 3306 for MySQL databases, if `:port` is `nil`
+(expect
+  (assoc (default-mysql-spec "") :dbname nil)
+  (db.spec/mysql
+   {:host    "localhost"
+    :port            nil
+    :dbname          nil
+    :db              nil}))