-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: RED Flight Example #733
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #733 +/- ##
===========================================
+ Coverage 76.08% 76.09% +0.01%
===========================================
Files 95 95
Lines 10997 10995 -2
===========================================
Hits 8367 8367
+ Misses 2630 2628 -2 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once again, naming the folder after the team name is risky, since this may not be the last rocket we use as an example from this team.
The apogee should be quite near 3000m, since the rocket has an airbrake model. Are you sure the air brakes have worked during this simulation? 8.6% of accuracy is too much, I was expecting something below 2% for this model (of course I could be wrong about this.
I personally recommend you to not mention the "last simulated apogee before launch", instead just mention the simulation we have obtained right now.
Plus, we need to add this new rocket to the flight examples comparison plot.
The airbrakes did work, since the apogee was 3300 meters and is now 3180m. I have an idea for an improvement to that value, based on using the actuation curve of the controller designed by the team. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LUCKIN13 it looks like you have duplicated the example notebook.
@Gui-FernandesBR thanks for calling out my distraction! I think it's finally ready! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pull request type
Checklist
black rocketpy/ tests/
) has passed locallypytest tests -m slow --runslow
) have passed locallyCHANGELOG.md
has been updated (if relevant)Additional information
This branch still needs some data reviews since the simulation file was developed in an older version of RocketPy. However, reviews can already be made, since the example should only suffer minor changes, if needed.
Changelog and Index for examples will be updated in other flight example, to prevent conflicts.