Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: added missing migration file #722

Merged

Conversation

mohamedelabbas1996
Copy link
Contributor

Summary

Added missing migration file 0017_alter_algorithm_unique_together.py for the Algorithm name,version unique constraint

Copy link

netlify bot commented Feb 13, 2025

Deploy Preview for ami-dev canceled.

Name Link
🔨 Latest commit 4d55f02
🔍 Latest deploy log https://app.netlify.com/sites/ami-dev/deploys/67b2ed8685cd6e0008b69567

@vanessavmac
Copy link
Collaborator

Hey @mohamedelabbas1996 ! I ran makemigrations on main and found another missing migration file: ami/main/migrations/0045_alter_classification_algorithm.py

If it's alright, I commited it to this branch to merge as one fix

@mihow
Copy link
Collaborator

mihow commented Feb 16, 2025

@vanessavmac great call, thanks for adding to the missing migrations. @mohamedelabbas1996 thanks for making this PR.

Are the tests passing for you locally?

@mohamedelabbas1996
Copy link
Contributor Author

Hi @mihow and @vanessavmac. No, tests are not passing locally for me I have the same error even after reset_db and manage.py makemigrations , manage.py migrate.

Copy link
Collaborator

@mihow mihow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on a recent snapshot of the production DB

@mihow mihow merged commit 7eb05a1 into main Feb 17, 2025
6 checks passed
@mihow mihow deleted the fix/add-missing-migration-algorithm-name-version-unique-constraint branch February 17, 2025 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants