Skip to content

Commit

Permalink
lib: libsmbclient: Ensure cli_rename() always sets cli->raw_status.
Browse files Browse the repository at this point in the history
Identical change as used in cli_unlink(), cli_mkdir(), cli_rmdir()
cli_chkpath() to ensure SMB2 calls correctly set raw_status for
libsmbclient uses.

Remove knownfail.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14938

Signed-off-by: Jeremy Allison <[email protected]>
Reviewed-by: Ralph Boehme <[email protected]>

Autobuild-User(master): Jeremy Allison <[email protected]>
Autobuild-Date(master): Wed Feb  2 21:50:31 UTC 2022 on sn-devel-184
  • Loading branch information
jrasamba committed Feb 2, 2022
1 parent 0ecc588 commit ca60f63
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 1 deletion.
1 change: 0 additions & 1 deletion selftest/knownfail.d/libsmbclient_rename

This file was deleted.

1 change: 1 addition & 0 deletions source3/libsmb/clifile.c
Original file line number Diff line number Diff line change
Expand Up @@ -1489,6 +1489,7 @@ NTSTATUS cli_rename(struct cli_state *cli,
}

status = cli_rename_recv(req);
cli->raw_status = status; /* cli_smb2_rename_recv doesn't set this */

fail:
TALLOC_FREE(frame);
Expand Down

0 comments on commit ca60f63

Please sign in to comment.