Merge pull request pimterry#6 from trengrj/check-editor

Test if $EDITOR set, fail if no editor can be found.
Rooyca · Dec 2, 2016 · 3e7bfee · 3e7bfee
2 parents e13b18d + 49654ac
commit 3e7bfee
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/notes b/notes
@@ -69,6 +69,10 @@ open_note() {
     if [ ! -f "$note_path" ]; then
         note_path="$notes_dir/$note_path"
     fi
+    if [ -z "$EDITOR" ]; then
+        printf "Please set \$EDITOR to edit notes\n"
+        exit 1
+    fi
 
     $EDITOR "$note_path" < /dev/tty
 }

diff --git a/test/test-open.bats b/test/test-open.bats
@@ -29,6 +29,13 @@ notes="./notes"
   assert_output "Opening $HOME/notes" 
 }
 
+@test "Exits if EDITOR not configured" {
+  unset EDITOR
+  run $notes open test
+
+  assert_failure
+}
+
 @test "Opens the configured notes directory if set" {
   run $notes open