Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest version check and other improvements #21

Merged
2 commits merged into from
Jan 3, 2024
Merged

Latest version check and other improvements #21

2 commits merged into from
Jan 3, 2024

Conversation

ghost
Copy link

@ghost ghost commented Dec 22, 2023

  • adds function to check for latest version now that the repo is public 😍
  • adds binary name and version to http user agent used by all AWS SDK clients
  • improves goroutine responsible for handling and passing in keyboard input. golang select blocks wait on multiple channels and executes the case statement of the first one it receives data from. in this case, sometimes the 50 millisecond wait was triggering when a user was in the middle of sending input. this caused random characters to sometimes not be sent. increasing the timeout means its far less likely to occur.
  • minor function cleanup and reorganization

@ghost ghost self-requested a review as a code owner December 22, 2023 17:08
rue-tpratt
rue-tpratt previously approved these changes Dec 22, 2023
rue-amccarthy
rue-amccarthy previously approved these changes Dec 22, 2023
Copy link

@rue-amccarthy rue-amccarthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat

@ghost ghost dismissed stale reviews from rue-amccarthy and rue-tpratt via c0fdbcd January 3, 2024 17:36
@ghost ghost changed the title check for latest version and shift around where version string lives Latest version check and other improvements Jan 3, 2024
@ghost ghost merged commit 2b2057b into main Jan 3, 2024
@ghost ghost deleted the version-checker branch January 3, 2024 19:23
@ghost ghost deleted a comment from github-actions bot Jan 3, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants