Skip to content

Commit

Permalink
Increase server setup timeouts in integration tests (#1254)
Browse files Browse the repository at this point in the history
  • Loading branch information
likawind authored May 1, 2023
1 parent 575f922 commit dc25d6c
Show file tree
Hide file tree
Showing 7 changed files with 38 additions and 40 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/integration-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
- uses: actions/checkout@v2

- uses: ./.github/actions/setup-server
timeout-minutes: 5
timeout-minutes: 7

# TODO(ENG-2537): Use our separate GH actions credentials.
- uses: ./.github/actions/fetch-test-config
Expand Down Expand Up @@ -65,7 +65,7 @@ jobs:
- uses: actions/checkout@v2

- uses: ./.github/actions/setup-server
timeout-minutes: 5
timeout-minutes: 7

# TODO(ENG-2537): Use our separate GH actions credentials.
- uses: ./.github/actions/fetch-test-config
Expand Down Expand Up @@ -95,7 +95,7 @@ jobs:
- uses: actions/checkout@v2

- uses: ./.github/actions/setup-server
timeout-minutes: 5
timeout-minutes: 7

# TODO(ENG-2537): Use our separate GH actions credentials.
- uses: ./.github/actions/fetch-test-config
Expand Down
5 changes: 2 additions & 3 deletions .github/workflows/lint-golang.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,13 @@ on:
workflow_dispatch:
pull_request:
paths:
- 'src/golang/**'
- "src/golang/**"

jobs:
golangci:
name: lint
runs-on: ubuntu-latest
timeout-minutes: 5
timeout-minutes: 7
steps:
- uses: actions/checkout@v2

Expand Down Expand Up @@ -49,4 +49,3 @@ jobs:

# Optional: if set to true then the action don't cache or restore ~/.cache/go-build.
# skip-build-cache: true

8 changes: 4 additions & 4 deletions .github/workflows/mypy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,16 @@ name: Mypy
on:
pull_request:
paths:
- 'sdk/aqueduct/**'
- 'src/python/**'
- "sdk/aqueduct/**"
- "src/python/**"

jobs:
sdk:
runs-on: ubuntu-latest
timeout-minutes: 5
strategy:
matrix:
python-version: ['3.7', '3.8', '3.9', '3.10']
python-version: ["3.7", "3.8", "3.9", "3.10"]

name: Mypy SDK
steps:
Expand Down Expand Up @@ -40,7 +40,7 @@ jobs:
timeout-minutes: 5
strategy:
matrix:
python-version: ['3.8', '3.9', '3.10']
python-version: ["3.8", "3.9", "3.10"]

name: Mypy Executor
steps:
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/periodic-integration-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
- uses: actions/checkout@v2

- uses: ./.github/actions/setup-server
timeout-minutes: 5
timeout-minutes: 7

# TODO(ENG-2537): Use our separate GH actions credentials.
- uses: ./.github/actions/fetch-test-config
Expand Down Expand Up @@ -106,7 +106,7 @@ jobs:
- uses: actions/checkout@v2

- uses: ./.github/actions/setup-server
timeout-minutes: 5
timeout-minutes: 7

- uses: conda-incubator/setup-miniconda@v2
with:
Expand Down Expand Up @@ -204,7 +204,7 @@ jobs:
- uses: actions/checkout@v2

- uses: ./.github/actions/setup-server
timeout-minutes: 5
timeout-minutes: 7

- uses: ./.github/actions/fetch-test-config
with:
Expand Down
26 changes: 13 additions & 13 deletions .github/workflows/regression-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
strategy:
matrix:
# These are all the Python versions that we want to regression test with.
python-version: ['3.7', '3.8', '3.9', '3.10']
python-version: ["3.7", "3.8", "3.9", "3.10"]

name: Run Regressions Tests with Python Version ${{ matrix.python-version }}
steps:
Expand All @@ -22,7 +22,7 @@ jobs:

- name: Set filename for the prev ver server's output logs
run: echo "SERVER_LOGS_PREV_FILE=logs/server_logs_prev_ver_${{ matrix.python-version }}" >> $GITHUB_ENV

- name: Set filename for the current ver server's output logs
run: echo "SERVER_LOGS_CURRENT_FILE=logs/server_logs_curr_ver_${{ matrix.python-version }}" >> $GITHUB_ENV

Expand Down Expand Up @@ -51,7 +51,7 @@ jobs:
- name: Wait for server
timeout-minutes: 1
run: while ! echo exit | nc localhost 8080; do sleep 1; done

- name: Fetch the API key
run: echo "API_KEY=$(aqueduct apikey)" >> $GITHUB_ENV

Expand All @@ -68,7 +68,7 @@ jobs:
timeout-minutes: 5
run: imgname=old-flow-run-1 npx playwright test tests/screenshot.test.ts

- name: Trigger new workflow run
- name: Trigger new workflow run
working-directory: regression_tests
timeout-minutes: 5
run: npx playwright test tests/trigger.test.ts --project=chromium
Expand All @@ -82,22 +82,22 @@ jobs:
working-directory: regression_tests
timeout-minutes: 5
run: sleep 5 && python3 tests/workflow_comparer.py --server_address localhost:8080 --checkpoint=create --path=checkpoint

# Grabs the pid of the process bound to port 8080 and kills it
- name: Kill the server
run: kill -9 $(lsof -nP -iTCP -sTCP:LISTEN | grep 8080 | awk '{print $2}')

# install_local.py requires ~/.aqueduct to exist.
- name: Update aqueduct with latest code
run: python3 scripts/install_local.py --gobinary --sdk --executor

- name: Start the server again
run: (aqueduct start --verbose > $SERVER_LOGS_CURRENT_FILE 2>&1 &)

- name: Wait for server again
timeout-minutes: 5
run: while ! echo exit | nc localhost 8080; do sleep 1; done

- name: Compare checkpoint of workflow
working-directory: regression_tests
timeout-minutes: 5
Expand All @@ -107,16 +107,16 @@ jobs:
working-directory: regression_tests
timeout-minutes: 5
run: imgname=old-flow-run-2 npx playwright test tests/screenshot.test.ts

- name: Kill the server
run: kill -9 $(lsof -nP -iTCP -sTCP:LISTEN | grep 8080 | awk '{print $2}')

- name: clear the server
run: aqueduct clear

- name: Start the server again
run: (aqueduct start --verbose > $SERVER_LOGS_CURRENT_FILE 2>&1 &)

- name: Wait for server again
timeout-minutes: 5
run: while ! echo exit | nc localhost 8080; do sleep 1; done
Expand Down Expand Up @@ -145,9 +145,9 @@ jobs:
with:
name: Executor Logs
path: ~/.aqueduct/server/logs/*

- uses: actions/upload-artifact@v3
if: always()
with:
name: screenshots
path: regression_tests/screenshots
path: regression_tests/screenshots
24 changes: 12 additions & 12 deletions .github/workflows/run-notebooks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,14 @@ name: Run Notebooks
on:
workflow_dispatch:
push:
branches: [ main ]
branches: [main]
paths:
- 'src/golang/**'
- 'src/python/**'
- 'sdk/aqueduct/**'
- "src/golang/**"
- "src/python/**"
- "sdk/aqueduct/**"
pull_request:
paths:
- '.github/workflows/run-notebooks.yml'
- ".github/workflows/run-notebooks.yml"
- "examples/churn_prediction/Customer Churn Tutorial.ipynb"
- "examples/sentiment_analysis/Sentiment Model.ipynb"
- "examples/diabetes-classifier/Classifying Diabetes Risk.ipynb"
Expand All @@ -33,7 +33,7 @@ jobs:
- name: Set up Python 3.8
uses: actions/setup-python@v2
with:
python-version: '3.8'
python-version: "3.8"

- name: Set up GOPATH variable
run: echo "GOPATH=$(echo $HOME)" >> $GITHUB_ENV
Expand Down Expand Up @@ -117,7 +117,7 @@ jobs:
- name: Run Imported Function Notebook
timeout-minutes: 10
run: python3 examples/run_notebook.py --path "integration_tests/notebook/imported_function.ipynb"

- name: Run Util File Dependency Notebook
timeout-minutes: 10
run: python3 examples/run_notebook.py --path "integration_tests/notebook/util_dependency.ipynb"
Expand All @@ -133,10 +133,10 @@ jobs:
uses: ravsamhq/notify-slack-action@v1
with:
status: ${{ job.status }}
notification_title: ''
message_format: '{emoji} *{workflow}* has {status_message}'
footer: '{run_url}'
notify_when: 'failure,warnings'
mention_users: 'U025MDH5KS6,U01JEUX1J2Y,U01J8Q1HUBC'
notification_title: ""
message_format: "{emoji} *{workflow}* has {status_message}"
footer: "{run_url}"
notify_when: "failure,warnings"
mention_users: "U025MDH5KS6,U01JEUX1J2Y,U01J8Q1HUBC"
env:
SLACK_WEBHOOK_URL: ${{ secrets.ACTION_MONITORING_SLACK }}
3 changes: 1 addition & 2 deletions .github/workflows/skipped-integration-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,5 +30,4 @@ jobs:
name: SDK Data Integration Tests
steps:
- run: |
exit 0
exit 0

0 comments on commit dc25d6c

Please sign in to comment.