Skip to content

Commit

Permalink
init/main.c: fix symbol shadows noise
Browse files Browse the repository at this point in the history
The symbol 'call' is a static symbol used for initcall_debug.  This same
symbol name is used locally by a couple functions and produces the
following sparse warnings:

	warning: symbol 'call' shadows an earlier one

Fix this noise by renaming the local symbols.

Signed-off-by: H Hartley Sweeten <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
H Hartley Sweeten authored and torvalds committed Dec 15, 2009
1 parent 4d00928 commit 196a15b
Showing 1 changed file with 9 additions and 9 deletions.
18 changes: 9 additions & 9 deletions init/main.c
Original file line number Diff line number Diff line change
Expand Up @@ -691,10 +691,10 @@ asmlinkage void __init start_kernel(void)
static void __init do_ctors(void)
{
#ifdef CONFIG_CONSTRUCTORS
ctor_fn_t *call = (ctor_fn_t *) __ctors_start;
ctor_fn_t *fn = (ctor_fn_t *) __ctors_start;

for (; call < (ctor_fn_t *) __ctors_end; call++)
(*call)();
for (; fn < (ctor_fn_t *) __ctors_end; fn++)
(*fn)();
#endif
}

Expand Down Expand Up @@ -755,10 +755,10 @@ extern initcall_t __initcall_start[], __initcall_end[], __early_initcall_end[];

static void __init do_initcalls(void)
{
initcall_t *call;
initcall_t *fn;

for (call = __early_initcall_end; call < __initcall_end; call++)
do_one_initcall(*call);
for (fn = __early_initcall_end; fn < __initcall_end; fn++)
do_one_initcall(*fn);

/* Make sure there is no pending stuff from the initcall sequence */
flush_scheduled_work();
Expand All @@ -785,10 +785,10 @@ static void __init do_basic_setup(void)

static void __init do_pre_smp_initcalls(void)
{
initcall_t *call;
initcall_t *fn;

for (call = __initcall_start; call < __early_initcall_end; call++)
do_one_initcall(*call);
for (fn = __initcall_start; fn < __early_initcall_end; fn++)
do_one_initcall(*fn);
}

static void run_init_process(char *init_filename)
Expand Down

0 comments on commit 196a15b

Please sign in to comment.