Skip to content

Commit

Permalink
gigaset: fix format string typo in CAPI dial command
Browse files Browse the repository at this point in the history
A missing dot lead to garbage characters being included in the
dial command generated from a CAPI CONNECT_REQ message, which
interestingly enough worked anyway, illustrating the resilience
of the device.

Impact: bugfix
Signed-off-by: Tilman Schmidt <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
tilmanschmidt authored and davem330 committed Oct 29, 2009
1 parent 6c91191 commit 22077eb
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/isdn/gigaset/capi.c
Original file line number Diff line number Diff line change
Expand Up @@ -1254,7 +1254,7 @@ static void do_connect_req(struct gigaset_capi_ctr *iif,
commands[AT_DIAL] = kmalloc(l+3, GFP_KERNEL);
if (!commands[AT_DIAL])
goto oom;
snprintf(commands[AT_DIAL], l+3, "D%*s\r", l, pp);
snprintf(commands[AT_DIAL], l+3, "D%.*s\r", l, pp);

/* encode parameter: Calling party number */
pp = cmsg->CallingPartyNumber;
Expand Down

0 comments on commit 22077eb

Please sign in to comment.