Skip to content

Commit

Permalink
net: af_key: use seq_hlist_foo() helpers
Browse files Browse the repository at this point in the history
Simplify seq_file code.

Signed-off-by: Li Zefan <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
Li Zefan authored and davem330 committed Feb 10, 2010
1 parent efaffb7 commit 27b5b86
Showing 1 changed file with 3 additions and 17 deletions.
20 changes: 3 additions & 17 deletions net/key/af_key.c
Original file line number Diff line number Diff line change
Expand Up @@ -3654,9 +3654,8 @@ static const struct net_proto_family pfkey_family_ops = {
#ifdef CONFIG_PROC_FS
static int pfkey_seq_show(struct seq_file *f, void *v)
{
struct sock *s;
struct sock *s = sk_entry(v);

s = (struct sock *)v;
if (v == SEQ_START_TOKEN)
seq_printf(f ,"sk RefCnt Rmem Wmem User Inode\n");
else
Expand All @@ -3675,30 +3674,17 @@ static void *pfkey_seq_start(struct seq_file *f, loff_t *ppos)
{
struct net *net = seq_file_net(f);
struct netns_pfkey *net_pfkey = net_generic(net, pfkey_net_id);
struct sock *s;
struct hlist_node *node;
loff_t pos = *ppos;

read_lock(&pfkey_table_lock);
if (pos == 0)
return SEQ_START_TOKEN;

sk_for_each(s, node, &net_pfkey->table)
if (pos-- == 1)
return s;

return NULL;
return seq_hlist_start_head(&net_pfkey->table, *ppos);
}

static void *pfkey_seq_next(struct seq_file *f, void *v, loff_t *ppos)
{
struct net *net = seq_file_net(f);
struct netns_pfkey *net_pfkey = net_generic(net, pfkey_net_id);

++*ppos;
return (v == SEQ_START_TOKEN) ?
sk_head(&net_pfkey->table) :
sk_next((struct sock *)v);
return seq_hlist_next(v, &net_pfkey->table, ppos);
}

static void pfkey_seq_stop(struct seq_file *f, void *v)
Expand Down

0 comments on commit 27b5b86

Please sign in to comment.