Skip to content

Commit

Permalink
arch/i386/* fs/* ipc/*: mark variables with uninitialized_var()
Browse files Browse the repository at this point in the history
Mark variables with uninitialized_var() if such a warning appears,
and analysis proves that the var is initialized properly on all paths
it is used.

Signed-off-by: Jeff Garzik <[email protected]>
  • Loading branch information
Jeff Garzik committed Jul 17, 2007
1 parent a6343af commit 8e1c091
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 6 deletions.
2 changes: 1 addition & 1 deletion arch/i386/kernel/efi.c
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@ void efi_memmap_walk(efi_freemem_callback_t callback, void *arg)
struct range {
unsigned long start;
unsigned long end;
} prev, curr;
} uninitialized_var(prev), curr;
efi_memory_desc_t *md;
unsigned long start, end;
void *p;
Expand Down
3 changes: 2 additions & 1 deletion fs/ocfs2/file.c
Original file line number Diff line number Diff line change
Expand Up @@ -1867,7 +1867,8 @@ static ssize_t ocfs2_file_buffered_write(struct file *file, loff_t *ppos,
loff_t pos;
const struct iovec *cur_iov = iov;
struct page *user_page, *page;
char *buf, *dst;
char * uninitialized_var(buf);
char *dst;
void *fsdata;

/*
Expand Down
2 changes: 1 addition & 1 deletion fs/udf/super.c
Original file line number Diff line number Diff line change
Expand Up @@ -1356,7 +1356,7 @@ udf_load_partition(struct super_block *sb, kernel_lb_addr *fileset)
case UDF_VIRTUAL_MAP15:
case UDF_VIRTUAL_MAP20:
{
kernel_lb_addr ino;
kernel_lb_addr uninitialized_var(ino);

if (!UDF_SB_LASTBLOCK(sb))
{
Expand Down
4 changes: 2 additions & 2 deletions ipc/msg.c
Original file line number Diff line number Diff line change
Expand Up @@ -385,7 +385,7 @@ copy_msqid_from_user(struct msq_setbuf *out, void __user *buf, int version)
asmlinkage long sys_msgctl(int msqid, int cmd, struct msqid_ds __user *buf)
{
struct kern_ipc_perm *ipcp;
struct msq_setbuf setbuf;
struct msq_setbuf uninitialized_var(setbuf);
struct msg_queue *msq;
int err, version;
struct ipc_namespace *ns;
Expand Down Expand Up @@ -509,7 +509,7 @@ asmlinkage long sys_msgctl(int msqid, int cmd, struct msqid_ds __user *buf)
err = audit_ipc_obj(ipcp);
if (err)
goto out_unlock_up;
if (cmd==IPC_SET) {
if (cmd == IPC_SET) {
err = audit_ipc_set_perm(setbuf.qbytes, setbuf.uid, setbuf.gid,
setbuf.mode);
if (err)
Expand Down
2 changes: 1 addition & 1 deletion ipc/sem.c
Original file line number Diff line number Diff line change
Expand Up @@ -856,7 +856,7 @@ static int semctl_down(struct ipc_namespace *ns, int semid, int semnum,
{
struct sem_array *sma;
int err;
struct sem_setbuf setbuf;
struct sem_setbuf uninitialized_var(setbuf);
struct kern_ipc_perm *ipcp;

if(cmd == IPC_SET) {
Expand Down

0 comments on commit 8e1c091

Please sign in to comment.