forked from torvalds/linux
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Rewrite grace period code to unify management of grace period across lockd and nfsd. The current code has lockd and nfsd cooperate to compute a grace period which is satisfactory to them both, and then individually enforce it. This creates a slight race condition, since the enforcement is not coordinated. It's also more complicated than necessary. Here instead we have lockd and nfsd each inform common code when they enter the grace period, and when they're ready to leave the grace period, and allow normal locking only after both of them are ready to leave. We also expect the locks_start_grace()/locks_end_grace() interface here to be simpler to build on for future cluster/high-availability work, which may require (for example) putting individual filesystems into grace, or enforcing grace periods across multiple cluster nodes. Signed-off-by: J. Bruce Fields <[email protected]>
- Loading branch information
J. Bruce Fields
committed
Oct 3, 2008
1 parent
d5b337b
commit af558e3
Showing
10 changed files
with
104 additions
and
61 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| /* | ||
| * Common code for control of lockd and nfsv4 grace periods. | ||
| */ | ||
|
|
||
| #include <linux/module.h> | ||
| #include <linux/lockd/bind.h> | ||
|
|
||
| static LIST_HEAD(grace_list); | ||
| static DEFINE_SPINLOCK(grace_lock); | ||
|
|
||
| /** | ||
| * locks_start_grace | ||
| * @lm: who this grace period is for | ||
| * | ||
| * A grace period is a period during which locks should not be given | ||
| * out. Currently grace periods are only enforced by the two lock | ||
| * managers (lockd and nfsd), using the locks_in_grace() function to | ||
| * check when they are in a grace period. | ||
| * | ||
| * This function is called to start a grace period. | ||
| */ | ||
| void locks_start_grace(struct lock_manager *lm) | ||
| { | ||
| spin_lock(&grace_lock); | ||
| list_add(&lm->list, &grace_list); | ||
| spin_unlock(&grace_lock); | ||
| } | ||
| EXPORT_SYMBOL_GPL(locks_start_grace); | ||
|
|
||
| /** | ||
| * locks_end_grace | ||
| * @lm: who this grace period is for | ||
| * | ||
| * Call this function to state that the given lock manager is ready to | ||
| * resume regular locking. The grace period will not end until all lock | ||
| * managers that called locks_start_grace() also call locks_end_grace(). | ||
| * Note that callers count on it being safe to call this more than once, | ||
| * and the second call should be a no-op. | ||
| */ | ||
| void locks_end_grace(struct lock_manager *lm) | ||
| { | ||
| spin_lock(&grace_lock); | ||
| list_del_init(&lm->list); | ||
| spin_unlock(&grace_lock); | ||
| } | ||
| EXPORT_SYMBOL_GPL(locks_end_grace); | ||
|
|
||
| /** | ||
| * locks_in_grace | ||
| * | ||
| * Lock managers call this function to determine when it is OK for them | ||
| * to answer ordinary lock requests, and when they should accept only | ||
| * lock reclaims. | ||
| */ | ||
| int locks_in_grace(void) | ||
| { | ||
| return !list_empty(&grace_list); | ||
| } | ||
| EXPORT_SYMBOL_GPL(locks_in_grace); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.