Skip to content

Commit

Permalink
rtc/m41t80: use rtc_valid_tm() to check returned tm
Browse files Browse the repository at this point in the history
Use rtc_valid_tm() to check returned struct rtc_time *tm - it can avoid
returning wrong tm value.

Signed-off-by: Wan ZongShun <[email protected]>
Cc: Alessandro Zummo <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
zswan authored and torvalds committed Aug 11, 2010
1 parent d6c7428 commit b485fe5
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/rtc/rtc-m41t80.c
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ static int m41t80_get_datetime(struct i2c_client *client,

/* assume 20YY not 19YY, and ignore the Century Bit */
tm->tm_year = bcd2bin(buf[M41T80_REG_YEAR]) + 100;
return 0;
return rtc_valid_tm(tm);
}

/* Sets the given date and time to the real time clock. */
Expand Down Expand Up @@ -364,7 +364,7 @@ static int m41t80_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *t)
t->time.tm_isdst = -1;
t->enabled = !!(reg[M41T80_REG_ALARM_MON] & M41T80_ALMON_AFE);
t->pending = !!(reg[M41T80_REG_FLAGS] & M41T80_FLAGS_AF);
return 0;
return rtc_valid_tm(t);
}

static struct rtc_class_ops m41t80_rtc_ops = {
Expand Down

0 comments on commit b485fe5

Please sign in to comment.