Skip to content

Commit

Permalink
pnpbios: convert to use the kthread API
Browse files Browse the repository at this point in the history
This patches modifies the pnpbios kernel thread to start with ktrhead_run
not kernel_thread and deamonize.  Doing this makes the code a little
simpler and easier to maintain.

Signed-off-by: Eric W. Biederman <[email protected]>
Cc: Adam Belay <[email protected]>
Cc: Bjorn Helgaas <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
ebiederm authored and Linus Torvalds committed May 8, 2007
1 parent 1bd0cf1 commit db9c02f
Showing 1 changed file with 7 additions and 9 deletions.
16 changes: 7 additions & 9 deletions drivers/pnp/pnpbios/core.c
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@
#include <linux/delay.h>
#include <linux/acpi.h>
#include <linux/freezer.h>
#include <linux/kthread.h>

#include <asm/page.h>
#include <asm/desc.h>
Expand Down Expand Up @@ -159,9 +160,7 @@ static int pnp_dock_thread(void * unused)
{
static struct pnp_docking_station_info now;
int docked = -1, d = 0;
daemonize("kpnpbiosd");
allow_signal(SIGKILL);
while(!unloading && !signal_pending(current))
while (!unloading)
{
int status;

Expand All @@ -170,11 +169,8 @@ static int pnp_dock_thread(void * unused)
*/
msleep_interruptible(2000);

if(signal_pending(current)) {
if (try_to_freeze())
continue;
break;
}
if (try_to_freeze())
continue;

status = pnp_bios_dock_station_info(&now);

Expand Down Expand Up @@ -581,6 +577,7 @@ subsys_initcall(pnpbios_init);

static int __init pnpbios_thread_init(void)
{
struct task_struct *task;
#if defined(CONFIG_PPC_MERGE)
if (check_legacy_ioport(PNPBIOS_BASE))
return 0;
Expand All @@ -589,7 +586,8 @@ static int __init pnpbios_thread_init(void)
return 0;
#ifdef CONFIG_HOTPLUG
init_completion(&unload_sem);
if (kernel_thread(pnp_dock_thread, NULL, CLONE_KERNEL) > 0)
task = kthread_run(pnp_dock_thread, NULL, "kpnpbiosd");
if (!IS_ERR(task))
unloading = 0;
#endif
return 0;
Expand Down

0 comments on commit db9c02f

Please sign in to comment.