Skip to content

Commit

Permalink
Allow disabling of DSACK TCP option per route
Browse files Browse the repository at this point in the history
Add and use no DSCAK bit in the features field.

Signed-off-by: Gilad Ben-Yossef <[email protected]>
Sigend-off-by: Ori Finkelman <[email protected]>
Sigend-off-by: Yony Amit <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
Gilad Ben-Yossef authored and davem330 committed Oct 29, 2009
1 parent 345cda2 commit dc34347
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
1 change: 1 addition & 0 deletions include/linux/rtnetlink.h
Original file line number Diff line number Diff line change
Expand Up @@ -381,6 +381,7 @@ enum
#define RTAX_FEATURE_NO_TSTAMP 0x00000004
#define RTAX_FEATURE_ALLFRAG 0x00000008
#define RTAX_FEATURE_NO_WSCALE 0x00000010
#define RTAX_FEATURE_NO_DSACK 0x00000020

struct rta_session
{
Expand Down
8 changes: 6 additions & 2 deletions net/ipv4/tcp_input.c
Original file line number Diff line number Diff line change
Expand Up @@ -4080,8 +4080,10 @@ static inline int tcp_sack_extend(struct tcp_sack_block *sp, u32 seq,
static void tcp_dsack_set(struct sock *sk, u32 seq, u32 end_seq)
{
struct tcp_sock *tp = tcp_sk(sk);
struct dst_entry *dst = __sk_dst_get(sk);

if (tcp_is_sack(tp) && sysctl_tcp_dsack) {
if (tcp_is_sack(tp) && sysctl_tcp_dsack &&
!dst_feature(dst, RTAX_FEATURE_NO_DSACK)) {
int mib_idx;

if (before(seq, tp->rcv_nxt))
Expand Down Expand Up @@ -4110,13 +4112,15 @@ static void tcp_dsack_extend(struct sock *sk, u32 seq, u32 end_seq)
static void tcp_send_dupack(struct sock *sk, struct sk_buff *skb)
{
struct tcp_sock *tp = tcp_sk(sk);
struct dst_entry *dst = __sk_dst_get(sk);

if (TCP_SKB_CB(skb)->end_seq != TCP_SKB_CB(skb)->seq &&
before(TCP_SKB_CB(skb)->seq, tp->rcv_nxt)) {
NET_INC_STATS_BH(sock_net(sk), LINUX_MIB_DELAYEDACKLOST);
tcp_enter_quickack_mode(sk);

if (tcp_is_sack(tp) && sysctl_tcp_dsack) {
if (tcp_is_sack(tp) && sysctl_tcp_dsack &&
!dst_feature(dst, RTAX_FEATURE_NO_DSACK)) {
u32 end_seq = TCP_SKB_CB(skb)->end_seq;

if (after(TCP_SKB_CB(skb)->end_seq, tp->rcv_nxt))
Expand Down

0 comments on commit dc34347

Please sign in to comment.