Fix stacktrace warning (hexpm#763)

RyanSiu1995 · Mar 1, 2020 · 513312b · 513312b
1 parent a393cef
commit 513312b
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/lib/hex.ex b/lib/hex.ex
@@ -97,6 +97,14 @@ defmodule Hex do
     def enum_split_with(enum, fun), do: Enum.split_with(enum, fun)
   end
 
+  defmacro stacktrace() do
+    if Version.compare(System.version(), "1.7.0") == :lt do
+      quote do: System.stacktrace()
+    else
+      quote do: __STACKTRACE__
+    end
+  end
+
   def file_lstat(path, opts \\ []) do
     opts = Keyword.put_new(opts, :time, :universal)
 

diff --git a/lib/hex/scm.ex b/lib/hex/scm.ex
@@ -172,7 +172,8 @@ defmodule Hex.SCM do
         Hex.unpack_tar!(path, dest)
       rescue
         exception ->
-          stacktrace = System.stacktrace()
+          require Hex
+          stacktrace = Hex.stacktrace()
           File.rm(path)
           reraise(exception, stacktrace)
       end

diff --git a/lib/mix/tasks/hex.publish.ex b/lib/mix/tasks/hex.publish.ex
@@ -227,7 +227,8 @@ defmodule Mix.Tasks.Hex.Publish do
       Mix.Task.run("docs", ["--canonical", canonical])
     rescue
       ex in [Mix.NoTaskError] ->
-        stacktrace = System.stacktrace()
+        require Hex
+        stacktrace = Hex.stacktrace()
 
         Mix.shell().error("""
         Publication failed because the "docs" task is unavailable. You may resolve this by: