kvm: let clock scale setting apply immediately #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you mention in one of the commit messages why this change was made? I think it's good to note these things for future reference. |
vitalych
force-pushed
the
clock-scale-fix
branch
from
5b296e5 to
9510de6
Compare
|
@adrianherrera I mentioned it in the code. People don't really read commit messages. |
|
Hey, I read commit messages! :( Especially to see why a change was made. I was more after an explanation of why it was changed from an integer to a pointer. But sure, have at it. |
adrianherrera
approved these changes
Nov 21, 2017
|
Ok, good point, I will update the explanations |
Changed it to a pointer because we cannot wait for kvm_run to return. Interrupts may happen while kvm_run is running and we want these interrupts to take into account the new clock speed. Signed-off-by: Vitaly Chipounov <[email protected]>
vitalych
force-pushed
the
clock-scale-fix
branch
from
9510de6 to
31405db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vitaly Chipounov [email protected]