Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pw/support cpu #18

Merged
merged 2 commits into from
Jul 27, 2023
Merged

Pw/support cpu #18

merged 2 commits into from
Jul 27, 2023

Conversation

PrestonH2O
Copy link
Contributor

Removed references to cuda in tests and CabannaController.hpp, changing memory and execution spaces. This allows serial runs so that code coverage will be able to pick up code it otherwise wouldn't due to being run on gpus.

Tested both CPU and GPU runs of this build.

@cwsmith
Copy link
Contributor

cwsmith commented Jul 27, 2023

@PrestonH2O Thank you. Please remove the 'Implemented testing code coverage' commit. I typically do this with a git rebase -i on the command line followed by a force push to the branch (git push origin pw/supportCPU --force). The force push is needed since we are rewriting the history of the branch.

@cwsmith cwsmith self-requested a review July 27, 2023 18:16
Copy link
Contributor

@cwsmith cwsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you. There is one small change noted in my comment.

@cwsmith cwsmith merged commit 38d9505 into NM-Rework Jul 27, 2023
@PrestonH2O PrestonH2O deleted the pw/supportCPU branch July 27, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants