Skip to content

Commit

Permalink
Modified default <p> rule to fix Hotmail's style overriding. When com…
Browse files Browse the repository at this point in the history
…posing, paragraphs are now spaced correctly when rendered.
  • Loading branch information
adam-p committed Feb 5, 2013
1 parent dfcecf6 commit 5f321bb
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 5 deletions.
5 changes: 2 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -162,11 +162,10 @@ Short answer: Gmail and Thunderbird are great. More info about some clients can
</tr>
<tr>
<th>Hotmail</th>
<td>Paragraphs don't appear spaced correctly. (But they do appear spaced correctly when viewed by recipients.)</td>
<td>&#x2713;</td>
<td>&#x2713;</td>
<td>
Email from received from Yahoo does not display with properly separated paragraphs. (Hotmail strips styling off <code>&lt;p&gt;</code> and <code>&lt;div&gt;</code> tags, and Yahoo uses the latter for paragraphs.)<p>
Code blocks with very dark backgrounds aren't displayed correctly.
Email received from Yahoo does not display with properly separated paragraphs. (Hotmail strips styling off <code>&lt;p&gt;</code> and <code>&lt;div&gt;</code> tags, and Yahoo uses the latter for paragraphs.)
</td>
<td>No reply exclusion.</td>
</tr>
Expand Down
2 changes: 2 additions & 0 deletions src/common/CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ Change Log

* Added a "Basic Usage" section to the options page. This is in response to [a tweet](https://twitter.com/KSuzukiii/status/294376172295446528) from user KSuzukii.

* Yahoo and Outlook.com (Hotmail) now work a bit better.

2013-01-02: v2.6.4
------------------

Expand Down
11 changes: 9 additions & 2 deletions src/common/default.css
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,13 @@ pre code {
}

/* This spacing has been tweaked to closely match Gmail+Chrome "paragraph" (two line breaks) spacing. */
p, table, pre, dl, blockquote, q, ul, ol {
p {
/* !important is needed here because Hotmail/Outlook.com uses !important to
kill the margin in <p>. We need this to win. */
margin: 1.2em 0 !important;
}

table, pre, dl, blockquote, q, ul, ol {
margin: 1.2em 0;
}

Expand All @@ -55,7 +61,8 @@ li {

/* Space paragraphs in a list the same as the list itself. */
li p {
margin: 0.5em 0;
/* Needs !important to override rule above. */
margin: 0.5em 0 !important;
}

/* Smaller spacing for sub-lists */
Expand Down
Binary file added store-assets/dos-equis-MDH.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 5f321bb

Please sign in to comment.