CIFS: remove an unneeded NULL check

Smatch complains because we dereference "ses->server" without checking some lines earlier inside the call to get_next_mid(ses->server). fs/cifs/cifssmb.c:4921 CIFSGetDFSRefer() warn: variable dereferenced before check 'ses->server' (see line 4899) There is only one caller for this function get_dfs_path() and it always passes a non-null "ses->server" pointer so this NULL check can be removed. Signed-off-by: Dan Carpenter <[email protected]> Signed-off-by: Steve French <[email protected]>
SKAPUSTIANSKYI · May 20, 2015 · 65c3b20 · 65c3b20
1 parent 1dc92c4
commit 65c3b20
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/fs/cifs/cifssmb.c b/fs/cifs/cifssmb.c
@@ -4918,7 +4918,7 @@ CIFSGetDFSRefer(const unsigned int xid, struct cifs_ses *ses,
 		strncpy(pSMB->RequestFileName, search_name, name_len);
 	}
 
-	if (ses->server && ses->server->sign)
+	if (ses->server->sign)
 		pSMB->hdr.Flags2 |= SMBFLG2_SECURITY_SIGNATURE;
 
 	pSMB->hdr.Uid = ses->Suid;