Skip to content

Commit

Permalink
Fix integration create bug
Browse files Browse the repository at this point in the history
  • Loading branch information
bastienbeurier committed Apr 24, 2023
1 parent bd67e75 commit 405f676
Show file tree
Hide file tree
Showing 8 changed files with 90 additions and 23 deletions.
73 changes: 69 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/cli/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "nango",
"version": "0.10.4",
"version": "0.15.0",
"description": "Nango's CLI tool.",
"type": "module",
"main": "dist/index.js",
Expand Down
2 changes: 1 addition & 1 deletion packages/frontend/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@nangohq/frontend",
"version": "0.14.0",
"version": "0.15.0",
"description": "Nango's frontend library for OAuth handling.",
"type": "module",
"main": "dist/index.js",
Expand Down
2 changes: 1 addition & 1 deletion packages/node-client/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@nangohq/node",
"version": "0.10.4",
"version": "0.15.0",
"description": "Nango's Node client.",
"type": "module",
"main": "dist/index.js",
Expand Down
2 changes: 1 addition & 1 deletion packages/server/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@nangohq/nango-server",
"version": "0.14.1",
"version": "0.15.1",
"description": "Nango OAuth's server.",
"type": "module",
"main": "dist/server.js",
Expand Down
19 changes: 10 additions & 9 deletions packages/webapp/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions packages/webapp/package.json
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
{
"name": "webapp",
"version": "0.14.0",
"version": "0.15.0",
"private": true,
"dependencies": {
"@geist-ui/core": "^2.3.8",
"@geist-ui/icons": "^1.0.2",
"@headlessui/react": "^1.7.12",
"@heroicons/react": "^2.0.16",
"@mantine/prism": "^5.10.5",
"@nangohq/frontend": "^0.14.0",
"@nangohq/frontend": "^0.15.0",
"@testing-library/jest-dom": "^5.16.5",
"@testing-library/react": "^13.4.0",
"@testing-library/user-event": "^13.5.0",
Expand Down
9 changes: 5 additions & 4 deletions packages/webapp/src/pages/IntegrationCreate.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ export default function IntegrationCreate() {
const createIntegrationAPI = useCreateIntegrationAPI();
const deleteIntegrationAPI = useDeleteIntegrationAPI();
const [selectedProvider, setSelectedProvider] = useState<string>('my-integration');
const [providerDefaultScope, setProviderDefaultScope] = useState<string[]|undefined>(undefined)
const [providerDefaultScope, setProviderDefaultScope] = useState<string[] | undefined>(undefined);

useEffect(() => {
const getProviders = async () => {
Expand Down Expand Up @@ -93,8 +93,7 @@ export default function IntegrationCreate() {
const handleIntegrationProviderChange = (e: React.ChangeEvent<HTMLSelectElement>) => {
let [provider, defaultScope] = e.target.value.split('|');
setSelectedProvider(provider);
setProviderDefaultScope(defaultScope?.split(','))

setProviderDefaultScope(defaultScope?.split(','));
};

const handleSave = async (e: React.SyntheticEvent) => {
Expand Down Expand Up @@ -207,7 +206,9 @@ export default function IntegrationCreate() {
onChange={handleIntegrationProviderChange}
>
{providers.map((provider, key) => (
<option key={key} value={`${provider.name}|${provider.defaultScopes?.join(',')}`}>{provider.name}</option>
<option key={key} value={`${provider.name}`}>
{provider.name}
</option>
))}
</select>
</div>
Expand Down

0 comments on commit 405f676

Please sign in to comment.