Update to typescript 3.6.3 (keybase#19190)

shared/actions/__tests__/signup.test.tsx

@@ -10,7 +10,7 @@ import * as RouteTreeGen from '../route-tree-gen'
 import {_testing} from '../signup'
 import reducer from '../../reducers/signup'
 
-const testLogger = new SagaLogger('TESTING', 'TESTINGFCN')
+const testLogger = new SagaLogger('TESTING' as any, 'TESTINGFCN')
 
 jest.unmock('immutable')
 

shared/actions/chat2/index.tsx

@@ -115,18 +115,16 @@ function* inboxRefresh(
     )
   }
 
-  yield* Saga.callRPCs(
-    RPCChatTypes.localGetInboxNonblockLocalRpcSaga({
-      incomingCallMap: {'chat.1.chatUi.chatInboxUnverified': onUnverified},
-      params: {
-        identifyBehavior: RPCTypes.TLFIdentifyBehavior.chatGui,
-        maxUnbox: 0,
-        query: Constants.makeInboxQuery([]),
-        skipUnverified: false,
-      },
-      waitingKey: Constants.waitingKeyInboxRefresh,
-    })
-  )
+  yield RPCChatTypes.localGetInboxNonblockLocalRpcSaga({
+    incomingCallMap: {'chat.1.chatUi.chatInboxUnverified': onUnverified},
+    params: {
+      identifyBehavior: RPCTypes.TLFIdentifyBehavior.chatGui,
+      maxUnbox: 0,
+      query: Constants.makeInboxQuery([]),
+      skipUnverified: false,
+    },
+    waitingKey: Constants.waitingKeyInboxRefresh,
+  })
 }
 
 // When we get info on a team we need to unbox immediately so we can get the channel names
@@ -2152,7 +2150,7 @@ function* attachmentDownload(
   }
 
   // Download it
-  const destPath = yield* Saga.callPromise(downloadFilePath, message.fileName)
+  const destPath = yield downloadFilePath(message.fileName)
   yield Saga.callUntyped(downloadAttachment, destPath, message)
 }
 
@@ -2516,7 +2514,7 @@ function* mobileMessageAttachmentShare(
   }
   const fileName = yield* downloadAttachment('', message)
   try {
-    yield* Saga.callPromise(showShareActionSheetFromFile, fileName, message.fileType)
+    yield showShareActionSheetFromFile(fileName)
   } catch (e) {
     logger.error('Failed to share attachment: ' + JSON.stringify(e))
   }
@@ -2546,7 +2544,7 @@ function* mobileMessageAttachmentSave(
   )
   try {
     logger.info('Trying to save chat attachment to camera roll')
-    yield* Saga.callPromise(saveAttachmentToCameraRoll, fileName, message.fileType)
+    yield saveAttachmentToCameraRoll(fileName, message.fileType)
   } catch (err) {
     logger.error('Failed to save attachment: ' + err)
     throw new Error('Failed to save attachment: ' + err)
@@ -3394,15 +3392,15 @@ const createConversationFromTeamBuilder = (
   }),
 ]
 
-export function* chatTeamBuildingSaga(): Saga.SagaGenerator<any, any> {
+export function* chatTeamBuildingSaga() {
   yield* commonTeamBuildingSaga('chat2')
   yield* Saga.chainAction2(
     TeamBuildingGen.finishedTeamBuilding,
     filterForNs('chat2', createConversationFromTeamBuilder)
   )
 }
 
-function* chat2Saga(): Saga.SagaGenerator<any, any> {
+function* chat2Saga() {
   // Platform specific actions
   if (isMobile) {
     // Push us into the conversation

shared/actions/config/index.tsx

@@ -270,7 +270,6 @@ function* loadDaemonAccounts(
           })
         )
       }
-      return undefined
     }
   }
 }
@@ -589,7 +588,7 @@ const saveDarkPrefs = async (state: Container.TypedState) => {
   } catch (_) {}
 }
 
-function* configSaga(): Saga.SagaGenerator<any, any> {
+function* configSaga() {
   // Start the handshake process. This means we tell all sagas we're handshaking with the daemon. If another
   // saga needs to do something before we leave the loading screen they should call daemonHandshakeWait
   yield* Saga.chainAction2([ConfigGen.restartHandshake, ConfigGen.startHandshake], startHandshake)

shared/actions/deeplinks.tsx

@@ -105,7 +105,7 @@ const handleAppLink = (state: Container.TypedState, action: DeeplinksGen.LinkPay
   return false
 }
 
-function* deeplinksSaga(): Saga.SagaGenerator<any, any> {
+function* deeplinksSaga() {
   yield* Saga.chainAction2(DeeplinksGen.link, handleAppLink)
   yield* Saga.chainAction2(DeeplinksGen.handleKeybaseLink, handleKeybaseLink)
 }

shared/actions/devices.tsx

@@ -22,22 +22,20 @@ const load = async (state: Container.TypedState) => {
   }
 }
 
-function* requestPaperKey(): Iterable<any> {
-  yield* Saga.callRPCs(
-    RPCTypes.loginPaperKeyRpcSaga({
-      customResponseIncomingCallMap: {
-        'keybase.1.loginUi.promptRevokePaperKeys': (_, response) => {
-          response.result(false)
-        },
+function* requestPaperKey() {
+  yield RPCTypes.loginPaperKeyRpcSaga({
+    customResponseIncomingCallMap: {
+      'keybase.1.loginUi.promptRevokePaperKeys': (_, response) => {
+        response.result(false)
       },
-      incomingCallMap: {
-        'keybase.1.loginUi.displayPaperKeyPhrase': ({phrase}) =>
-          Saga.put(DevicesGen.createPaperKeyCreated({paperKey: new HiddenString(phrase)})),
-      },
-      params: undefined,
-      waitingKey: Constants.waitingKey,
-    })
-  )
+    },
+    incomingCallMap: {
+      'keybase.1.loginUi.displayPaperKeyPhrase': ({phrase}) =>
+        Saga.put(DevicesGen.createPaperKeyCreated({paperKey: new HiddenString(phrase)})),
+    },
+    params: undefined,
+    waitingKey: Constants.waitingKey,
+  })
 }
 
 const requestEndangeredTLFsLoad = async (
@@ -128,7 +126,7 @@ const receivedBadgeState = (_: Container.TypedState, action: NotificationsGen.Re
     ],
   })
 
-function* deviceSaga(): Saga.SagaGenerator<any, any> {
+function* deviceSaga() {
   // Load devices
   yield* Saga.chainAction2([DevicesGen.load, DevicesGen.revoked, DevicesGen.paperKeyCreated], load)
   // Revoke device

shared/actions/fs/common.native.tsx

@@ -54,7 +54,7 @@ const downloadSuccess = async (state: TypedState, action: FsGen.DownloadSuccessP
   }
 }
 
-export default function* nativeSaga(): Saga.SagaGenerator<any, any> {
+export default function* nativeSaga() {
   yield* Saga.chainAction2(FsGen.pickAndUpload, pickAndUploadToPromise)
   yield* Saga.chainAction2(FsGen.downloadSuccess, downloadSuccess)
 }

shared/actions/fs/index.tsx

@@ -400,7 +400,7 @@ function* download(
     case Types.DownloadIntent.None:
       // This adds " (1)" suffix to the base name, if the destination path
       // already exists.
-      localPath = yield* Saga.callPromise(Constants.downloadFilePathFromPath, path)
+      localPath = yield Constants.downloadFilePathFromPath(path)
       break
     case Types.DownloadIntent.CameraRoll:
     case Types.DownloadIntent.Share:
@@ -411,7 +411,7 @@ function* download(
       break
     default:
       Flow.ifFlowComplainsAboutThisFunctionYouHaventHandledAllCasesInASwitch(intent)
-      localPath = yield* Saga.callPromise(Constants.downloadFilePathFromPath, path)
+      localPath = yield Constants.downloadFilePathFromPath(path)
       break
   }
 
@@ -709,7 +709,7 @@ function* loadPathMetadata(_: TypedState, action: FsGen.LoadPathMetadataPayload)
     let pathItem = makeEntry(dirent)
     if (pathItem.type === Types.PathType.File) {
       const mimeType = yield* _loadMimeType(path)
-      pathItem = pathItem.set('mimeType', mimeType)
+      pathItem = pathItem.set('mimeType', mimeType || null)
     }
     yield Saga.put(
       FsGen.createPathItemLoaded({
@@ -1008,7 +1008,7 @@ const loadPathInfo = async (_: TypedState, action: FsGen.LoadPathInfoPayload) =>
   })
 }
 
-function* fsSaga(): Saga.SagaGenerator<any, any> {
+function* fsSaga() {
   yield* Saga.chainAction2(FsGen.refreshLocalHTTPServerInfo, refreshLocalHTTPServerInfo)
   yield* Saga.chainAction2(FsGen.cancelDownload, cancelDownload)
   yield* Saga.chainGenerator<FsGen.DownloadPayload | FsGen.ShareNativePayload | FsGen.SaveMediaPayload>(

shared/actions/fs/platform-specific.android.tsx

@@ -63,7 +63,7 @@ const downloadSuccessAndroid = (state, action: FsGen.DownloadSuccessPayload) =>
   return copyToDownloadDir(localPath, mimeType)
 }
 
-export default function* platformSpecificSaga(): Saga.SagaGenerator<any, any> {
+export default function* platformSpecificSaga() {
   yield Saga.spawn(nativeSaga)
   yield* Saga.chainAction2(FsGen.downloadSuccess, downloadSuccessAndroid)
 }

shared/actions/fs/platform-specific.d.ts

@@ -1,6 +1,6 @@
 import * as Saga from '../../util/saga'
 import * as Types from '../../constants/types/fs'
 
-declare function platformSpecificSaga(): Saga.SagaGenerator<any, any>
+declare function platformSpecificSaga(): void
 
 export default platformSpecificSaga

shared/actions/fs/platform-specific.desktop.tsx

@@ -426,7 +426,7 @@ const refreshMountDirs = async (
   ]
 }
 
-function* platformSpecificSaga(): Saga.SagaGenerator<any, any> {
+function* platformSpecificSaga() {
   yield* Saga.chainAction2(FsGen.openLocalPathInSystemFileManager, openLocalPathInSystemFileManager)
   yield* Saga.chainAction2(FsGen.openPathInSystemFileManager, openPathInSystemFileManager)
   if (!isLinux) {

shared/actions/git.tsx

@@ -118,7 +118,7 @@ function* navigateToTeamRepo(state: TypedState, action: GitGen.NavigateToTeamRep
 const receivedBadgeState = (_: TypedState, action: NotificationsGen.ReceivedBadgeStatePayload) =>
   GitGen.createBadgeAppForGit({ids: new Set(action.payload.badgeState.newGitRepoGlobalUniqueIDs)})
 
-function* gitSaga(): Saga.SagaGenerator<any, any> {
+function* gitSaga() {
   // Create / Delete
   yield* Saga.chainAction2(GitGen.createPersonalRepo, createPersonalRepo)
   yield* Saga.chainAction2(GitGen.createTeamRepo, createTeamRepo)

shared/actions/gregor.tsx

@@ -86,7 +86,7 @@ const updateCategory = async (_: Container.TypedState, action: GregorGen.UpdateC
   } catch (_) {}
 }
 
-function* gregorSaga(): Saga.SagaGenerator<any, any> {
+function* gregorSaga() {
   yield* Saga.chainAction2(GregorGen.updateCategory, updateCategory)
   yield* Saga.chainAction2([GregorGen.checkReachability, ConfigGen.osNetworkStatusChanged], checkReachability)
   yield* Saga.chainAction2(EngineGen.connected, registerForGregorNotifications)

shared/actions/login.tsx

@@ -48,35 +48,33 @@ const moveToProvisioning = (username: string) => (_: any, response: any) => {
 // Actually do a user/pass login. Don't get sucked into a provisioning flow
 function* login(_: Container.TypedState, action: LoginGen.LoginPayload) {
   try {
-    yield* Saga.callRPCs(
-      RPCTypes.loginLoginRpcSaga({
-        customResponseIncomingCallMap: {
-          'keybase.1.gpgUi.selectKey': cancelOnCallback,
-          'keybase.1.loginUi.getEmailOrUsername': cancelOnCallback,
-          'keybase.1.provisionUi.DisplayAndPromptSecret': cancelOnCallback,
-          'keybase.1.provisionUi.PromptNewDeviceName': moveToProvisioning(action.payload.username),
-          'keybase.1.provisionUi.chooseDevice': cancelOnCallback,
-          'keybase.1.provisionUi.chooseGPGMethod': cancelOnCallback,
-          'keybase.1.secretUi.getPassphrase': getPasswordHandler(action.payload.password.stringValue()),
-        },
-        // cancel if we get any of these callbacks, we're logging in, not provisioning
-        incomingCallMap: {
-          'keybase.1.loginUi.displayPrimaryPaperKey': ignoreCallback,
-          'keybase.1.provisionUi.DisplaySecretExchanged': ignoreCallback,
-          'keybase.1.provisionUi.ProvisioneeSuccess': ignoreCallback,
-          'keybase.1.provisionUi.ProvisionerSuccess': ignoreCallback,
-        },
-        params: {
-          clientType: RPCTypes.ClientType.guiMain,
-          deviceName: '',
-          deviceType: isMobile ? 'mobile' : 'desktop',
-          doUserSwitch: flags.fastAccountSwitch,
-          paperKey: '',
-          username: action.payload.username,
-        },
-        waitingKey: Constants.waitingKey,
-      })
-    )
+    yield RPCTypes.loginLoginRpcSaga({
+      customResponseIncomingCallMap: {
+        'keybase.1.gpgUi.selectKey': cancelOnCallback,
+        'keybase.1.loginUi.getEmailOrUsername': cancelOnCallback,
+        'keybase.1.provisionUi.DisplayAndPromptSecret': cancelOnCallback,
+        'keybase.1.provisionUi.PromptNewDeviceName': moveToProvisioning(action.payload.username),
+        'keybase.1.provisionUi.chooseDevice': cancelOnCallback,
+        'keybase.1.provisionUi.chooseGPGMethod': cancelOnCallback,
+        'keybase.1.secretUi.getPassphrase': getPasswordHandler(action.payload.password.stringValue()),
+      },
+      // cancel if we get any of these callbacks, we're logging in, not provisioning
+      incomingCallMap: {
+        'keybase.1.loginUi.displayPrimaryPaperKey': ignoreCallback,
+        'keybase.1.provisionUi.DisplaySecretExchanged': ignoreCallback,
+        'keybase.1.provisionUi.ProvisioneeSuccess': ignoreCallback,
+        'keybase.1.provisionUi.ProvisionerSuccess': ignoreCallback,
+      },
+      params: {
+        clientType: RPCTypes.ClientType.guiMain,
+        deviceName: '',
+        deviceType: isMobile ? 'mobile' : 'desktop',
+        doUserSwitch: flags.fastAccountSwitch,
+        paperKey: '',
+        username: action.payload.username,
+      },
+      waitingKey: Constants.waitingKey,
+    })
     logger.info('login call succeeded')
     yield Saga.put(ConfigGen.createLoggedIn({causedBySignup: false, causedByStartup: false}))
   } catch (e) {
@@ -107,7 +105,7 @@ const loadIsOnline = async () => {
   }
 }
 
-function* loginSaga(): Saga.SagaGenerator<any, any> {
+function* loginSaga() {
   // Actually log in
   yield* Saga.chainGenerator<LoginGen.LoginPayload>(LoginGen.login, login)
   yield* Saga.chainAction2(LoginGen.launchForgotPasswordWebPage, launchForgotPasswordWebPage)

shared/actions/notifications.tsx

@@ -83,7 +83,7 @@ const receivedBoxAuditError = (
     ),
   })
 
-function* notificationsSaga(): Saga.SagaGenerator<any, any> {
+function* notificationsSaga() {
   yield* Saga.chainAction2(NotificationsGen.receivedBadgeState, receivedBadgeState)
   yield* Saga.chainAction2(EngineGen.keybase1NotifyAuditRootAuditError, receivedRootAuditError)
   yield* Saga.chainAction2(EngineGen.keybase1NotifyAuditBoxAuditError, receivedBoxAuditError)

shared/actions/people.tsx

@@ -44,7 +44,13 @@ const getPeopleData = async (state: Container.TypedState, action: PeopleGen.GetP
       .reduce(Constants.reduceRPCItemToPeopleItem, I.List())
 
     if (debugTodo) {
-      const allTodos: Array<RPCTypes.HomeScreenTodoType> = Object.values(RPCTypes.HomeScreenTodoType)
+      const allTodos = Object.values(RPCTypes.HomeScreenTodoType).reduce<Array<RPCTypes.HomeScreenTodoType>>(
+        (arr, t) => {
+          typeof t !== 'string' && arr.push(t)
+          return arr
+        },
+        []
+      )
       allTodos.forEach(avdlType => {
         const todoType = Constants.todoTypeEnumToType[avdlType]
         if (newItems.some(t => t.type === 'todo' && t.todoType === todoType)) {
@@ -157,7 +163,7 @@ const connected = async () => {
   }
 }
 
-const peopleSaga = function*(): Saga.SagaGenerator<any, any> {
+const peopleSaga = function*() {
   yield* Saga.chainAction2(PeopleGen.getPeopleData, getPeopleData)
   yield* Saga.chainAction2(PeopleGen.markViewed, markViewed)
   yield* Saga.chainAction2(PeopleGen.skipTodo, skipTodo)

shared/actions/pinentry.tsx

@@ -75,7 +75,7 @@ const onCancel = (_: Container.TypedState, action: PinentryGen.OnCancelPayload)
   })
 }
 
-function* pinentrySaga(): Saga.SagaGenerator<any, any> {
+function* pinentrySaga() {
   yield* Saga.chainAction2(PinentryGen.onSubmit, onSubmit)
   yield* Saga.chainAction2(PinentryGen.onCancel, onCancel)
   yield* Saga.chainAction2(PinentryGen.newPinentry, onNewPinentry)

shared/actions/plan-billing.tsx

@@ -1,5 +1,5 @@
 // import logger from '../logger'
-import * as Saga from '../util/saga'
+// import * as Saga from '../util/saga'
 // import * as Constants from '../constants/plan-billing'
 // import * as Types from '../constants/types/plan-billing'
 // import * as RPCTypes from '../constants/types/rpc-gen'
@@ -167,7 +167,7 @@ import * as Saga from '../util/saga'
 // }
 // }
 
-function* billingSaga(): Saga.SagaGenerator<any, any> {
+function* billingSaga() {
   // this isn't used
   // yield Saga.safeTakeEvery(Constants.updateBilling, updateBillingSaga)
   // yield Saga.safeTakeEvery(Constants.fetchBillingAndQuota, fetchBillingAndQuotaSaga)

shared/actions/platform-specific/index.d.ts

@@ -37,4 +37,4 @@ export declare function getContentTypeFromURL(
   }) => Promise<string> | void
 )
 
-export declare function platformConfigSaga(): Saga.SagaGenerator<any, any>
+export declare function platformConfigSaga()