Skip to content

Commit

Permalink
Fix wait banner (keybase#20592)
Browse files Browse the repository at this point in the history
* fix wait banner

* tweaks on troubleshooting screen

* lint

* storybook

* prettier
  • Loading branch information
cecileboucheron authored Oct 28, 2019
1 parent 5a280bd commit 162b36a
Show file tree
Hide file tree
Showing 4 changed files with 177 additions and 26 deletions.
3 changes: 2 additions & 1 deletion shared/provision/code-page/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,8 @@ class CodePage2 extends React.Component<Props, State> {
<Kb.BannerParagraph
bannerColor="yellow"
content={[
`Wait, I'm on that ${this.props.otherDeviceType === 'mobile' ? 'phone' : 'computer'} right now!`,
`Are you on that ${this.props.otherDeviceType === 'mobile' ? 'phone' : 'computer'} now? `,
{onClick: () => this.setState({troubleshooting: true}), text: 'Resolve'},
]}
/>
</Kb.Banner>
Expand Down
9 changes: 6 additions & 3 deletions shared/provision/troubleshooting/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ const Troubleshooting = (props: Props) => {
<Kb.Modal
onClose={onBack}
header={{
hideBorder: true,
hideBorder: false,
leftButton: Styles.isMobile ? (
<Kb.Text type="BodySemiboldLink" onClick={onBack}>
Back
Expand All @@ -94,8 +94,8 @@ const Troubleshooting = (props: Props) => {
mode="Wide"
>
<Kb.Box2 direction="vertical" gap="small" alignItems="center">
<Kb.Box2 direction="vertical">
<Kb.Text type="Body" center={true} style={styles.bodyMargins}>
<Kb.Box2 direction="vertical" style={styles.bodyMargins}>
<Kb.Text type="Body" center={true}>
This appears to be a new {Styles.isMobile ? 'phone' : 'computer'}. Perhaps you restored from a
backup or uninstalled Keybase. Either way, Keybase keys aren’t backed up, so this is now a totally
new device.
Expand Down Expand Up @@ -154,6 +154,9 @@ const styles = Styles.styleSheetCreate(() => ({
},
bodyMargins: Styles.platformStyles({
isElectron: Styles.padding(Styles.globalMargins.medium, Styles.globalMargins.xlarge, 0),
isMobile: {
padding: Styles.globalMargins.medium,
},
}),
buttonBar: {
marginLeft: Styles.globalMargins.medium,
Expand Down
7 changes: 5 additions & 2 deletions shared/settings/feedback/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ class Feedback extends React.Component<Props, State> {
<Kb.Box2 direction="horizontal" fullWidth={true}>
<Kb.NewInput
containerStyle={styles.input}
placeholder="Email (pretty please!)"
placeholder="Your email address"
onChangeText={this._onChangeEmail}
/>
</Kb.Box2>
Expand Down Expand Up @@ -172,7 +172,10 @@ const styles = Styles.styleSheetCreate(
isElectron: {padding: Styles.globalMargins.tiny},
isMobile: {...Styles.padding(Styles.globalMargins.tiny, Styles.globalMargins.small)},
}),
mainBox: {padding: Styles.globalMargins.small},
mainBox: Styles.platformStyles({
common: {padding: Styles.globalMargins.small},
isElectron: {width: 368},
}),
outerStyle: {backgroundColor: Styles.globalColors.white},
smallLabel: {color: Styles.globalColors.black},
} as const)
Expand Down
184 changes: 164 additions & 20 deletions shared/stories/__tests__/__snapshots__/Storyshots.test.js.snap

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 162b36a

Please sign in to comment.