Use Kb.Emoji for light mode sunglasses

SaltineChips · Sep 9, 2019 · 62ba72e · 62ba72e
1 parent 76c1135
commit 62ba72e
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 9 deletions.
diff --git a/shared/common-adapters/radio-button.d.ts b/shared/common-adapters/radio-button.d.ts
@@ -1,7 +1,7 @@
 import React, {Component} from 'react'
 
 export type Props = {
-  label: string
+  label: string | React.ReactNode
   onSelect: (selected: boolean) => void
   selected: boolean
   style?: Object

diff --git a/shared/settings/advanced/index.tsx b/shared/settings/advanced/index.tsx
@@ -117,19 +117,24 @@ const Advanced = (props: Props) => {
             <Kb.Divider style={styles.proxyDivider} />
             <Kb.Box2 direction="vertical" fullWidth={true}>
               <Kb.Text type="Body">Dark mode</Kb.Text>
+              {isDarwin && (
+                <Kb.RadioButton
+                  label="Respect system settings"
+                  selected={props.darkModePreference === 'system' || props.darkModePreference === undefined}
+                  onSelect={() => props.onSetDarkModePreference('system')}
+                />
+              )}
               <Kb.RadioButton
-                label="Respect system settings"
-                disabled={!isDarwin}
-                selected={props.darkModePreference === 'system' || props.darkModePreference === undefined}
-                onSelect={() => props.onSetDarkModePreference('system')}
-              />
-              <Kb.RadioButton
-                label="Dark all the time"
+                label="Dark"
                 selected={props.darkModePreference === 'alwaysDark'}
                 onSelect={() => props.onSetDarkModePreference('alwaysDark')}
               />
               <Kb.RadioButton
-                label="Light all the time 😎"
+                label={
+                  <Kb.Text type="Body">
+                    Light <Kb.Emoji size={16} emojiName=":sunglasses:" />
+                  </Kb.Text>
+                }
                 selected={props.darkModePreference === 'alwaysLight'}
                 onSelect={() => props.onSetDarkModePreference('alwaysLight')}
               />