add types and plumbing for listing popular assets from stellard (keyb…

…ase#17920)

go/client/cmd_wallet.go

@@ -25,6 +25,7 @@ func newCmdWallet(cl *libcmdline.CommandLine, g *libkb.GlobalContext) cli.Comman
 		newCmdWalletHistory(cl, g),
 		newCmdWalletImport(cl, g),
 		newCmdWalletLookup(cl, g),
+		newCmdWalletPopularAssets(cl, g),
 		newCmdWalletRename(cl, g),
 		newCmdWalletRequest(cl, g),
 		newCmdWalletSend(cl, g),

go/client/cmd_wallet_popular_assets.go

@@ -0,0 +1,62 @@
+package client
+
+import (
+	"errors"
+
+	"github.com/keybase/cli"
+	"github.com/keybase/client/go/libcmdline"
+	"github.com/keybase/client/go/libkb"
+	"golang.org/x/net/context"
+)
+
+func (c *cmdWalletPopularAssets) GetUsage() libkb.Usage {
+	return libkb.Usage{
+		API:       true,
+		KbKeyring: true,
+		Config:    true,
+	}
+}
+
+type cmdWalletPopularAssets struct {
+	libkb.Contextified
+}
+
+func newCmdWalletPopularAssets(cl *libcmdline.CommandLine, g *libkb.GlobalContext) cli.Command {
+	cmd := &cmdWalletPopularAssets{
+		Contextified: libkb.NewContextified(g),
+	}
+	return cli.Command{
+		Name:  "popular-assets",
+		Usage: "List popular assets",
+		Action: func(c *cli.Context) {
+			cl.ChooseCommand(cmd, "popular-assets", c)
+		},
+	}
+}
+
+func (c *cmdWalletPopularAssets) ParseArgv(ctx *cli.Context) error {
+	if len(ctx.Args()) != 0 {
+		return errors.New("listing popular assets expects no args")
+	}
+	return nil
+}
+
+func (c *cmdWalletPopularAssets) Run() (err error) {
+	defer transformStellarCLIError(&err)
+
+	cli, err := GetWalletClient(c.G())
+	if err != nil {
+		return err
+	}
+
+	assets, err := cli.ListPopularAssetsLocal(context.Background(), 0)
+	if err != nil {
+		return err
+	}
+	dui := c.G().UI.GetDumbOutputUI()
+	dui.Printf("popular assets:\n")
+	for _, asset := range assets {
+		dui.Printf(buildOutputStringForAsset(asset) + "\n")
+	}
+	return nil
+}

go/stellar/remote/interface.go

@@ -49,4 +49,5 @@ type Remoter interface {
 	FindPaymentPath(mctx libkb.MetaContext, query stellar1.PaymentPathQuery) (stellar1.PaymentPath, error)
 	PostAnyTransaction(mctx libkb.MetaContext, signedTx string) error
 	FuzzyAssetSearch(mctx libkb.MetaContext, arg stellar1.FuzzyAssetSearchArg) ([]stellar1.Asset, error)
+	ListPopularAssets(mctx libkb.MetaContext, arg stellar1.ListPopularAssetsArg) ([]stellar1.Asset, error)
 }

go/stellar/remote/remote.go

@@ -1133,3 +1133,21 @@ func FuzzyAssetSearch(mctx libkb.MetaContext, arg stellar1.FuzzyAssetSearchArg)
 	}
 	return apiRes.Assets, nil
 }
+
+type popularAssetsResult struct {
+	libkb.AppStatusEmbed
+	Assets []stellar1.Asset `json:"assets"`
+}
+
+func ListPopularAssets(mctx libkb.MetaContext, arg stellar1.ListPopularAssetsArg) ([]stellar1.Asset, error) {
+	apiArg := libkb.APIArg{
+		Endpoint:    "stellar/list_popular_assets",
+		SessionType: libkb.APISessionTypeREQUIRED,
+		Args:        libkb.HTTPArgs{},
+	}
+	var apiRes popularAssetsResult
+	if err := mctx.G().API.GetDecode(mctx, apiArg, &apiRes); err != nil {
+		return []stellar1.Asset{}, err
+	}
+	return apiRes.Assets, nil
+}

go/stellar/remote/remote_net.go

@@ -149,3 +149,7 @@ func (r *RemoteNet) PostAnyTransaction(mctx libkb.MetaContext, signedTx string)
 func (r *RemoteNet) FuzzyAssetSearch(mctx libkb.MetaContext, arg stellar1.FuzzyAssetSearchArg) ([]stellar1.Asset, error) {
 	return FuzzyAssetSearch(mctx, arg)
 }
+
+func (r *RemoteNet) ListPopularAssets(mctx libkb.MetaContext, arg stellar1.ListPopularAssetsArg) ([]stellar1.Asset, error) {
+	return ListPopularAssets(mctx, arg)
+}

go/stellar/stellar.go

@@ -2327,3 +2327,7 @@ func FindPaymentPath(mctx libkb.MetaContext, remoter remote.Remoter, source stel
 func FuzzyAssetSearch(mctx libkb.MetaContext, remoter remote.Remoter, arg stellar1.FuzzyAssetSearchArg) ([]stellar1.Asset, error) {
 	return remoter.FuzzyAssetSearch(mctx, arg)
 }
+
+func ListPopularAssets(mctx libkb.MetaContext, remoter remote.Remoter, arg stellar1.ListPopularAssetsArg) ([]stellar1.Asset, error) {
+	return remoter.ListPopularAssets(mctx, arg)
+}

go/stellar/stellarsvc/frontend.go

@@ -1236,3 +1236,18 @@ func (s *Server) FuzzyAssetSearchLocal(ctx context.Context, arg stellar1.FuzzyAs
 	}
 	return stellar.FuzzyAssetSearch(mctx, s.remoter, remoteArg)
 }
+
+func (s *Server) ListPopularAssetsLocal(ctx context.Context, sessionID int) (res []stellar1.Asset, err error) {
+	mctx, fin, err := s.Preamble(ctx, preambleArg{
+		RPCName:       "ListPopularAssetsLocal",
+		Err:           &err,
+		RequireWallet: true,
+	})
+	defer fin()
+	if err != nil {
+		return res, err
+	}
+
+	remoteArg := stellar1.ListPopularAssetsArg{}
+	return stellar.ListPopularAssets(mctx, s.remoter, remoteArg)
+}

go/stellar/stellarsvc/remote_mock_test.go

@@ -570,6 +570,10 @@ func (r *RemoteClientMock) FuzzyAssetSearch(_ libkb.MetaContext, _ stellar1.Fuzz
 	return nil, errors.New("not mocked")
 }
 
+func (r *RemoteClientMock) ListPopularAssets(_ libkb.MetaContext, _ stellar1.ListPopularAssetsArg) ([]stellar1.Asset, error) {
+	return nil, errors.New("not mocked")
+}
+
 func (r *RemoteClientMock) PostAnyTransaction(_ libkb.MetaContext, _ string) error {
 	return errors.New("post any transaction is not mocked")
 }

go/systests/stellar_client_test.go

@@ -732,4 +732,8 @@ func (s *stellarRetryClient) FuzzyAssetSearchLocal(ctx context.Context, arg stel
 	return s.cli.FuzzyAssetSearchLocal(ctx, arg)
 }
 
+func (s *stellarRetryClient) ListPopularAssetsLocal(ctx context.Context, sessionID int) (res []stellar1.Asset, err error) {
+	return s.cli.ListPopularAssetsLocal(ctx, sessionID)
+}
+
 var _ stellar1.LocalInterface = (*stellarRetryClient)(nil)

protocol/avdl/stellar1/local.avdl

@@ -546,6 +546,7 @@ protocol local {
 
   // search by user search string
   array<Asset> fuzzyAssetSearchLocal(int sessionID, string searchString);
+  array<Asset> listPopularAssetsLocal(int sessionID);
 
   // Trustline operations:
   // In addTrustline, limit is optional, if not supplied, max limit will be used.

protocol/avdl/stellar1/remote.avdl

@@ -325,6 +325,7 @@ protocol remote {
   array<Asset> assetSearch(string assetCode, string issuerAccountID);
   // search by user search string
   array<Asset> fuzzyAssetSearch(keybase1.UserVersion caller, string searchString);
+  array<Asset> listPopularAssets(keybase1.UserVersion caller);
 
   void changeTrustline(keybase1.UserVersion caller, string signedTransaction);