Skip to content

Commit

Permalink
ios moved (keybase#17855)
Browse files Browse the repository at this point in the history
  • Loading branch information
mlsteele authored Jun 11, 2019
1 parent 872b627 commit d7ca7b8
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 5 deletions.
1 change: 0 additions & 1 deletion shared/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,5 @@ keybase.framework
ios/AppStore_keybase.ios.KeybaseShare.mobileprovision
ios/AppStore_keybase.ios.mobileprovision
ios/dist
react-native/ios

main.jsbundle
4 changes: 2 additions & 2 deletions shared/docs/ios/running.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ Install xcode

1. `yarn rn-gobuild-ios` (build the go library)
1. `yarn rn-start ios` (start the packager)
1. `open react-native/ios/Keybase.xcworkspace` (Open workspace (not xcodeproj))
1. `open ios/Keybase.xcworkspace` (Open workspace (not xcodeproj))
1. In xcode, select the target `Keybase` and run.


Expand All @@ -29,7 +29,7 @@ Keybase team. Once you accept the invite, you should be able to
connect your phone to your computer and get XCode to build onto it.

However, you first have to edit
`react-native/ios/Keybase/AppDelegate.m` to use the bundler running on
`ios/Keybase/AppDelegate.m` to use the bundler running on
your computer. Look for the comment "Uncomment for prod JS in dev
mode" and follow the instructions there.

Expand Down
4 changes: 2 additions & 2 deletions shared/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@
"rn-build-android": "rm -rf ./android/app/build && ./react-native/buildAndroid.sh",
"rn-push-android": "./react-native/pushAndroid.sh",
"rn-packager-wipe-cache": "watchman watch-del-all && rm -rf node_modules && yarn && node ./react-native/wipe-cache.js",
"rn-test-ios": "xcodebuild test -project ./react-native/ios/Keybase.xcodeproj -scheme 'Keybase For Test' -destination 'platform=iOS Simulator,name=iPhone 6s,OS=9.3'",
"rn-jsbuild-ios": "mkdir -p react-native/ios/dist && react-native bundle --platform ios --dev false --entry-file index.ios.js --bundle-output react-native/ios/dist/main.jsbundle --sourcemap-output react-native/ios/dist/main.jsbundle.sourcemap",
"rn-test-ios": "xcodebuild test -project ./ios/Keybase.xcodeproj -scheme 'Keybase For Test' -destination 'platform=iOS Simulator,name=iPhone 6s,OS=9.3'",
"rn-jsbuild-ios": "mkdir -p ios/dist && react-native bundle --platform ios --dev false --entry-file index.ios.js --bundle-output ios/dist/main.jsbundle --sourcemap-output ios/dist/main.jsbundle.sourcemap",
"rn-jsbuild-android": "mkdir -p android/dist && react-native bundle --platform android --dev false --entry-file index.android.js --bundle-output android/dist/main.jsbundle --sourcemap-output android/dist/main.jsbundle.sourcemap",
"storybook": "cross-env-shell BABEL_ENV=yarn start-storybook -s . -p 6006",
"storybook-build": "cross-env-shell build-storybook -c .storybook -o .static-storybook",
Expand Down

0 comments on commit d7ca7b8

Please sign in to comment.