Skip to content

Commit

Permalink
Do not deprecate whole class but only constructors of Json::Reader.
Browse files Browse the repository at this point in the history
This should fix warning C4996 issued by Visual Studio in cases where
Json::Reader is not even used by client code.
  • Loading branch information
Christof Krüger authored and cdunn2001 committed Jan 20, 2018
1 parent 0ced843 commit edb4bdb
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion include/json/reader.h
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ namespace Json {
*
* \deprecated Use CharReader and CharReaderBuilder.
*/
class JSONCPP_DEPRECATED("Use CharReader and CharReaderBuilder instead") JSON_API Reader {
class JSON_API Reader {
public:
typedef char Char;
typedef const Char* Location;
Expand All @@ -52,11 +52,13 @@ class JSONCPP_DEPRECATED("Use CharReader and CharReaderBuilder instead") JSON_AP
/** \brief Constructs a Reader allowing all features
* for parsing.
*/
JSONCPP_DEPRECATED("Use CharReader and CharReaderBuilder instead")
Reader();

/** \brief Constructs a Reader allowing the specified feature set
* for parsing.
*/
JSONCPP_DEPRECATED("Use CharReader and CharReaderBuilder instead")
Reader(const Features& features);

/** \brief Read a Value from a <a HREF="http://www.json.org">JSON</a>
Expand Down

0 comments on commit edb4bdb

Please sign in to comment.