Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NUI] Rebase DevelNUI (22401) #6581

Merged
merged 17 commits into from
Jan 14, 2025
Merged

[NUI] Rebase DevelNUI (22401) #6581

merged 17 commits into from
Jan 14, 2025

Conversation

hinohie
Copy link
Contributor

@hinohie hinohie commented Jan 14, 2025

Rebase DevelNUI -> main

everLEEst and others added 17 commits January 14, 2025 18:43
@everLEEst
[NUI] NUI Language version upgrade
76a187b 
NUI Language version upgrade for 9.
[NUI] Reduce managed PropertyValue creation for VisualObject
9ba4b54 
Let we add 'using' mark for temerally used `PropertyValue`.

Optimize PropertyMap.Add() API if it is prepared.

It is knd of next-step. So current PR could be keep going on

Signed-off-by: Eunki, Hong <[email protected]>
[NUI] Remove unnecessary PInvoke calls
84d1f83 
PivotPoint, AnchorPoint, Position
[NUI] remove unnecessary PInvoke calls related with axis
8fafd73
[NUI] Remove unnecessary PInvoke calls related with SlideTransitionDi…
455207b 
…rection
[NUI] Remove unused C# bindings anymore
c9d2c8a
[NUI] Fix wrong params order for ParentOrigin position
abfac8f
@rabbitfor
[NUI] Check exception from native when get background color
b3c3731 
Signed-off-by: Jiyun Yang <[email protected]>
@everLEEst
[NUI] add asynchronous tasked animation play
d8185ca
@everLEEst
[NUI] Update dp and sp extension methods and sp converting.
4fd4103
@rabbitfor
[NUI] Add markup for some view properties using value type
23fff90 
This also includes PropertyMap optimizations to prevent value type being conveted to reference type again.

Signed-off-by: Jiyun Yang <[email protected]>
[NUI] Preload static values
2b8f3ef
@rabbitfor
[NUI] Add value type: control state
1e7d7f9 
(1) Introduce the value type of ControlState. It replaces ControlState implementation.
(2) Notify IsEnabled changed to control state outside of view.

Signed-off-by: Jiyun Yang <[email protected]>
@rabbitfor
[NUI] Rename State to ViewState
6f0adf3 
Signed-off-by: Jiyun Yang <[email protected]>
@bshsqa
[NUI] Adds version tag or Hides deprecated APIs
7cf4a08 
Signed-off-by: Seungho Baek <[email protected]>
@rabbitfor
[NUI] Handles null argument ControlState.Equals
b435f26 
Signed-off-by: Jiyun Yang <[email protected]>
[NUI] Version Update (22401)
d15914f 
Signed-off-by: Eunki, Hong <[email protected]>
@github-actions github-actions bot added the API13 label Jan 14, 2025
lwc0917
lwc0917 approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@lwc0917 lwc0917 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TizenAPI-Bot
Copy link
Collaborator

Public API Changed

Please follow the ACR process for the changed API below.

Added: 0, Removed: 65, Changed: 0

Removed

- /// <since_tizen>3</since_tizen
- [Obsolete]
- System.Single Tizen.NUI.BaseComponents.CustomView::GetHeightForWidth(System.Single)

- /// <since_tizen>3</since_tizen
- [Obsolete]
- System.Single Tizen.NUI.BaseComponents.CustomView::GetWidthForHeight(System.Single)

- /// <since_tizen>3</since_tizen
- [Obsolete]
- System.Void Tizen.NUI.BaseComponents.CustomView::OnStageConnection(System.Int32)

- /// <since_tizen>3</since_tizen
- [Obsolete]
- System.Void Tizen.NUI.BaseComponents.CustomView::OnStageDisconnection()

- /// <since_tizen>3</since_tizen
- [Obsolete]
- System.Void Tizen.NUI.BaseComponents.CustomView::OnStyleChange(Tizen.NUI.StyleManager,Tizen.NUI.StyleChangeType)

- /// <since_tizen>3</since_tizen
- [Obsolete]
- Tizen.NUI.BaseComponents.FlexContainer

- /// <since_tizen>3</since_tizen
- [Obsolete]
- Tizen.NUI.BaseComponents.FlexContainer/Alignment Tizen.NUI.BaseComponents.FlexContainer::AlignContent()

- /// <since_tizen>3</since_tizen
- [Obsolete]
- Tizen.NUI.BaseComponents.FlexContainer/Alignment Tizen.NUI.BaseComponents.FlexContainer::AlignItems()

- /// <since_tizen>3</since_tizen
- [Obsolete]
- Tizen.NUI.BaseComponents.FlexContainer/ContentDirectionType Tizen.NUI.BaseComponents.FlexContainer::ContentDirection()

- /// <since_tizen>3</since_tizen
- [Obsolete]
- Tizen.NUI.BaseComponents.FlexContainer/FlexDirectionType Tizen.NUI.BaseComponents.FlexContainer::FlexDirection()

- /// <since_tizen>3</since_tizen
- [Obsolete]
- Tizen.NUI.BaseComponents.FlexContainer/Justification Tizen.NUI.BaseComponents.FlexContainer::JustifyContent()

- /// <since_tizen>3</since_tizen
- [Obsolete]
- Tizen.NUI.BaseComponents.FlexContainer/WrapType Tizen.NUI.BaseComponents.FlexContainer::FlexWrap()

- /// <since_tizen>3</since_tizen
- [Obsolete]
- System.Void Tizen.NUI.BaseComponents.FlexContainer::.ctor()

- /// <since_tizen>3</since_tizen
- [Obsolete]
- Tizen.NUI.BaseComponents.FlexContainer/Alignment

- /// <since_tizen>3</since_tizen
- [Obsolete]
- static Tizen.NUI.BaseComponents.FlexContainer/Alignment Tizen.NUI.BaseComponents.FlexContainer/Alignment::AlignAuto

- /// <since_tizen>3</since_tizen
- [Obsolete]
- static Tizen.NUI.BaseComponents.FlexContainer/Alignment Tizen.NUI.BaseComponents.FlexContainer/Alignment::AlignCenter

- /// <since_tizen>3</since_tizen
- [Obsolete]
- static Tizen.NUI.BaseComponents.FlexContainer/Alignment Tizen.NUI.BaseComponents.FlexContainer/Alignment::AlignFlexEnd

- /// <since_tizen>3</since_tizen
- [Obsolete]
- static Tizen.NUI.BaseComponents.FlexContainer/Alignment Tizen.NUI.BaseComponents.FlexContainer/Alignment::AlignFlexStart

- /// <since_tizen>3</since_tizen
- [Obsolete]
- static Tizen.NUI.BaseComponents.FlexContainer/Alignment Tizen.NUI.BaseComponents.FlexContainer/Alignment::AlignStretch

- /// <since_tizen>3</since_tizen
- [Obsolete]
- Tizen.NUI.BaseComponents.FlexContainer/ContentDirectionType

- /// <since_tizen>3</since_tizen
- [Obsolete]
- static Tizen.NUI.BaseComponents.FlexContainer/ContentDirectionType Tizen.NUI.BaseComponents.FlexContainer/ContentDirectionType::Inherit

- /// <since_tizen>3</since_tizen
- [Obsolete]
- static Tizen.NUI.BaseComponents.FlexContainer/ContentDirectionType Tizen.NUI.BaseComponents.FlexContainer/ContentDirectionType::LTR

- /// <since_tizen>3</since_tizen
- [Obsolete]
- static Tizen.NUI.BaseComponents.FlexContainer/ContentDirectionType Tizen.NUI.BaseComponents.FlexContainer/ContentDirectionType::RTL

- /// <since_tizen>3</since_tizen
- [Obsolete]
- Tizen.NUI.BaseComponents.FlexContainer/FlexDirectionType

- /// <since_tizen>3</since_tizen
- [Obsolete]
- static Tizen.NUI.BaseComponents.FlexContainer/FlexDirectionType Tizen.NUI.BaseComponents.FlexContainer/FlexDirectionType::Column

- /// <since_tizen>3</since_tizen
- [Obsolete]
- static Tizen.NUI.BaseComponents.FlexContainer/FlexDirectionType Tizen.NUI.BaseComponents.FlexContainer/FlexDirectionType::ColumnReverse

- /// <since_tizen>3</since_tizen
- [Obsolete]
- static Tizen.NUI.BaseComponents.FlexContainer/FlexDirectionType Tizen.NUI.BaseComponents.FlexContainer/FlexDirectionType::Row

- /// <since_tizen>3</since_tizen
- [Obsolete]
- static Tizen.NUI.BaseComponents.FlexContainer/FlexDirectionType Tizen.NUI.BaseComponents.FlexContainer/FlexDirectionType::RowReverse

- /// <since_tizen>3</since_tizen
- [Obsolete]
- Tizen.NUI.BaseComponents.FlexContainer/Justification

- /// <since_tizen>3</since_tizen
- [Obsolete]
- static Tizen.NUI.BaseComponents.FlexContainer/Justification Tizen.NUI.BaseComponents.FlexContainer/Justification::JustifyCenter

- /// <since_tizen>3</since_tizen
- [Obsolete]
- static Tizen.NUI.BaseComponents.FlexContainer/Justification Tizen.NUI.BaseComponents.FlexContainer/Justification::JustifyFlexEnd

- /// <since_tizen>3</since_tizen
- [Obsolete]
- static Tizen.NUI.BaseComponents.FlexContainer/Justification Tizen.NUI.BaseComponents.FlexContainer/Justification::JustifyFlexStart

- /// <since_tizen>3</since_tizen
- [Obsolete]
- static Tizen.NUI.BaseComponents.FlexContainer/Justification Tizen.NUI.BaseComponents.FlexContainer/Justification::JustifySpaceAround

- /// <since_tizen>3</since_tizen
- [Obsolete]
- static Tizen.NUI.BaseComponents.FlexContainer/Justification Tizen.NUI.BaseComponents.FlexContainer/Justification::JustifySpaceBetween

- /// <since_tizen>3</since_tizen
- [Obsolete]
- Tizen.NUI.BaseComponents.FlexContainer/WrapType

- /// <since_tizen>3</since_tizen
- [Obsolete]
- static Tizen.NUI.BaseComponents.FlexContainer/WrapType Tizen.NUI.BaseComponents.FlexContainer/WrapType::NoWrap

- /// <since_tizen>3</since_tizen
- [Obsolete]
- static Tizen.NUI.BaseComponents.FlexContainer/WrapType Tizen.NUI.BaseComponents.FlexContainer/WrapType::Wrap

- /// <since_tizen>3</since_tizen
- [Obsolete]
- System.Boolean Tizen.NUI.BaseComponents.ImageView::SynchronosLoading()

- /// <since_tizen>3</since_tizen
- [Obsolete]
- Tizen.NUI.BaseComponents.Scrollable

- /// <since_tizen>3</since_tizen
- [Obsolete]
- System.Boolean Tizen.NUI.BaseComponents.Scrollable::CanScrollHorizontal()

- /// <since_tizen>3</since_tizen
- [Obsolete]
- System.Boolean Tizen.NUI.BaseComponents.Scrollable::CanScrollVertical()

- /// <since_tizen>3</since_tizen
- [Obsolete]
- System.Boolean Tizen.NUI.BaseComponents.Scrollable::OvershootEnabled()

- /// <since_tizen>3</since_tizen
- [Obsolete]
- System.Int32 Tizen.NUI.BaseComponents.Scrollable::ScrollToAlphaFunction()

- /// <since_tizen>3</since_tizen
- [Obsolete]
- System.Single Tizen.NUI.BaseComponents.Scrollable::OvershootAnimationSpeed()

- /// <since_tizen>3</since_tizen
- [Obsolete]
- Tizen.NUI.Vector2 Tizen.NUI.BaseComponents.Scrollable::OvershootSize()

- /// <since_tizen>3</since_tizen
- [Obsolete]
- Tizen.NUI.Vector2 Tizen.NUI.BaseComponents.Scrollable::ScrollPositionMax()

- /// <since_tizen>3</since_tizen
- [Obsolete]
- Tizen.NUI.Vector2 Tizen.NUI.BaseComponents.Scrollable::ScrollPositionMin()

- /// <since_tizen>3</since_tizen
- [Obsolete]
- Tizen.NUI.Vector2 Tizen.NUI.BaseComponents.Scrollable::ScrollRelativePosition()

- /// <since_tizen>3</since_tizen
- [Obsolete]
- Tizen.NUI.Vector4 Tizen.NUI.BaseComponents.Scrollable::OvershootEffectColor()

- /// <since_tizen>3</since_tizen
- [Obsolete]
- System.Void Tizen.NUI.BaseComponents.Scrollable::.ctor()

- /// <since_tizen>3</since_tizen
- [Obsolete]
- System.Void Tizen.NUI.BaseComponents.Scrollable::Dispose(Tizen.NUI.DisposeTypes)

- /// <since_tizen>3</since_tizen
- [Obsolete]
- Tizen.NUI.DaliEventHandler`2<System.Object,Tizen.NUI.BaseComponents.Scrollable/CompletedEventArgs> Tizen.NUI.BaseComponents.Scrollable::ScrollCompleted

- /// <since_tizen>3</since_tizen
- [Obsolete]
- Tizen.NUI.DaliEventHandler`2<System.Object,Tizen.NUI.BaseComponents.Scrollable/StartedEventArgs> Tizen.NUI.BaseComponents.Scrollable::ScrollStarted

- /// <since_tizen>3</since_tizen
- [Obsolete]
- Tizen.NUI.DaliEventHandler`2<System.Object,Tizen.NUI.BaseComponents.Scrollable/UpdatedEventArgs> Tizen.NUI.BaseComponents.Scrollable::ScrollUpdated

- /// <since_tizen>3</since_tizen
- [Obsolete]
- Tizen.NUI.BaseComponents.Scrollable/CompletedEventArgs

- /// <since_tizen>3</since_tizen
- Tizen.NUI.Vector2 Tizen.NUI.BaseComponents.Scrollable/CompletedEventArgs::Vector2()

- /// <since_tizen>none</since_tizen
- System.Void Tizen.NUI.BaseComponents.Scrollable/CompletedEventArgs::.ctor()

- /// <since_tizen>3</since_tizen
- [Obsolete]
- Tizen.NUI.BaseComponents.Scrollable/StartedEventArgs

- /// <since_tizen>3</since_tizen
- Tizen.NUI.Vector2 Tizen.NUI.BaseComponents.Scrollable/StartedEventArgs::Vector2()

- /// <since_tizen>none</since_tizen
- System.Void Tizen.NUI.BaseComponents.Scrollable/StartedEventArgs::.ctor()

- /// <since_tizen>3</since_tizen
- [Obsolete]
- Tizen.NUI.BaseComponents.Scrollable/UpdatedEventArgs

- /// <since_tizen>3</since_tizen
- Tizen.NUI.Vector2 Tizen.NUI.BaseComponents.Scrollable/UpdatedEventArgs::Vector2()

- /// <since_tizen>none</since_tizen
- System.Void Tizen.NUI.BaseComponents.Scrollable/UpdatedEventArgs::.ctor()

- /// <since_tizen>3</since_tizen
- [Obsolete]
- System.Void Tizen.NUI.BaseComponents.TableView::SetCellPadding(Tizen.NUI.Size2D)

- /// <since_tizen>3</since_tizen
- [Obsolete]
- Tizen.NUI.Vector2 Tizen.NUI.BaseComponents.TableView::GetCellPadding()

Internal API Changed

Added: 150, Removed: 4, Changed: 0

Seoyeon2Kim
Seoyeon2Kim approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@Seoyeon2Kim Seoyeon2Kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So many files were changed!

@hinohie hinohie merged commit 8220376 into Samsung:main Jan 14, 2025
3 checks passed
@hinohie hinohie deleted the rebase-develnui-250114 branch January 14, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lwc0917 lwc0917 lwc0917 approved these changes

@Seoyeon2Kim Seoyeon2Kim Seoyeon2Kim approved these changes

@hyunjushin hyunjushin Awaiting requested review from hyunjushin

@dongsug-song dongsug-song Awaiting requested review from dongsug-song dongsug-song is a code owner

@taehyub taehyub Awaiting requested review from taehyub taehyub is a code owner

@jaehyun0cho jaehyun0cho Awaiting requested review from jaehyun0cho jaehyun0cho is a code owner

@everLEEst everLEEst Awaiting requested review from everLEEst everLEEst is a code owner

@rabbitfor rabbitfor Awaiting requested review from rabbitfor rabbitfor is a code owner

Assignees
No one assigned
Labels
ACR Accepted API13 Internal API Changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@hinohie @TizenAPI-Bot @Seoyeon2Kim @lwc0917 @everLEEst @rabbitfor @bshsqa