os/fs : Add "vFAT" file system support in TizenRT #2827

NilabhShant · 2019-03-22T04:44:32Z

This PR contains commits required to add vFAT file system in TizenRT and add functionality support for the same.
This patch has been back-ported from Nuttx.

seinfra · 2019-03-22T05:00:18Z

Target : [0e0eea3431e81a59d49b7ae93b1db1b5049d5b08] - Code Rule Check (C++) OK.

seinfra · 2019-03-22T05:00:41Z

Target : [0e0eea3431e81a59d49b7ae93b1db1b5049d5b08] - Code Rule Check Result:
os/fs/inode/inode.h:149: ERROR: [IDT_M_TAB] please, no spaces at the start of a line
os/fs/inode/inode.h:150: ERROR: [IDT_M_TAB] please, no spaces at the start of a line
os/fs/inode/inode.h:151: ERROR: [IDT_M_TAB] please, no spaces at the start of a line
os/fs/inode/inode.h:152: ERROR: [IDT_M_TAB] please, no spaces at the start of a line
os/fs/inode/inode.h:153: ERROR: [IDT_M_TAB] please, no spaces at the start of a line
os/fs/inode/inode.h:155: ERROR: [IDT_M_TAB] please, no spaces at the start of a line
os/fs/inode/inode.h:156: ERROR: [IDT_M_TAB] please, no spaces at the start of a line
os/fs/inode/inode.h:157: ERROR: [IDT_M_TAB] please, no spaces at the start of a line
os/include/tinyara/fs/dirent.h:95: ERROR: [IDT_M_TAB] please, no spaces at the start of a line
os/include/tinyara/fs/dirent.h:96: ERROR: [IDT_M_TAB] please, no spaces at the start of a line
os/include/tinyara/fs/dirent.h:97: ERROR: [IDT_M_TAB] please, no spaces at the start of a line
os/include/tinyara/fs/dirent.h:98: ERROR: [IDT_M_TAB] please, no spaces at the start of a line
os/include/tinyara/fs/dirent.h:175: ERROR: [IDT_M_TAB] please, no spaces at the start of a line

os/fs/fat/Kconfig

sunghan-chang · 2019-03-22T05:32:43Z

os/fs/inode/inode.h

+ */
+
+struct inode_search_s {
+  FAR const char *path;      /* Path of inode to find */


coding rule

Thanks, Done

sunghan-chang · 2019-03-22T05:33:36Z

os/include/sys/mount.h

@@ -66,6 +66,7 @@
 /****************************************************************************
 * Included Files
 ****************************************************************************/
+#include <tinyara/compiler.h>


Why do you include this header? Your new codes do not require it.

Ok, I delete it
Please check

sunghan-chang · 2019-03-22T05:33:47Z

os/include/tinyara/fs/dirent.h

+  off_t        fd_startcluster;        /* Start cluster number of the directory */
+  off_t        fd_currcluster;         /* Current cluster number being read */
+  off_t        fd_currsector;          /* Current sector being read */
+  unsigned int fd_index;               /* Current index of the directory entry to read */


coding rule

sunghan-chang · 2019-03-22T05:34:04Z

os/include/tinyara/fs/fat.h

+#define FATATTR_ARCHIVE   0x20
+
+#define FATATTR_LONGNAME \
+  (FATATTR_READONLY|FATATTR_HIDDEN|FATATTR_SYSTEM|FATATTR_VOLUMEID)


coding rule

sunghan-chang · 2019-03-22T05:34:25Z

os/include/tinyara/fs/fat.h

+
+int fat_getattrib(FAR const char *path, FAR fat_attrib_t *attrib);
+int fat_setattrib(FAR const char *path, fat_attrib_t setbits,
+                  fat_attrib_t clearbits);


Please check this file for coding rule

Done. please check

sunghan-chang · 2019-03-22T05:35:42Z

@NilabhShant Could you check is it ok for patent?

thapav · 2019-03-22T06:26:53Z

os/fs/fat/Make.defs

+#
+###########################################################################
+############################################################################
+# Make.defs


Correct Path >
os/fs/fat/Make.defs

Ok, Modified.
Please check

seinfra · 2019-03-22T10:46:18Z

Target : [fe684acc626551a1018afa84355904cdc9a403c4] - Code Rule Check (C++) OK.

seinfra · 2019-03-22T10:51:15Z

Target : [fe684acc626551a1018afa84355904cdc9a403c4] - Code Rule Check OK.

seinfra · 2019-03-22T11:18:51Z

Target : [cea4041483fdb1a9c95e954277a72b32af3c185a] - Code Rule Check (C++) OK.

seinfra · 2019-03-22T11:19:38Z

Target : [cea4041483fdb1a9c95e954277a72b32af3c185a] - Code Rule Check OK.

yashwanth686007 · 2019-03-25T06:49:33Z

os/fs/fat/fs_fat32.c

+
+	/* Sanity checks */
+
+	DEBUGASSERT(filep->f_priv == NULL && filep->f_inode != NULL);


Also check for "filep" variable.

is it necessary to check for it because if filep is NULL then its members will be NULL .

Yes, it might result in assertion.

yashwanth686007 · 2019-03-25T06:55:20Z

os/fs/fat/fs_fat32.c

+
+		/* Synchronize the file buffers and disk content; update times */
+
+		ret = fat_sync(filep);


No need to check whether sync is successful?

It is returning the status of sync at the end and this logic working fine in nuttx so its better to have it like this.

yashwanth686007 · 2019-03-25T06:58:54Z

os/fs/fat/fs_fat32.c

+	 * both the "." and ".." entries.
+	 */
+
+	else {


Please correct coding guideline violation

yashwanth686007 · 2019-03-25T07:04:29Z

os/fs/fat/Kconfig

+# see kconfig-language at https://www.kernel.org/doc/Documentation/kbuild/kconfig-language.txt
+#
+
+config FS_FAT


Is only FAT32 is supported ? Or other versions too?

As per my knowledge vFAT and FAT32

yes only FAT32 support

seinfra · 2019-03-26T06:15:51Z

Target : [168c77a8f7fde4579c7c518c842c6129ca84a2c8] - Code Rule Check (C++) OK.

seinfra · 2019-03-26T06:16:03Z

Target : [168c77a8f7fde4579c7c518c842c6129ca84a2c8] - Code Rule Check OK.

sangam-swami · 2019-03-26T14:11:03Z

os/fs/fat/fs_fat32.c

+ *     reserved.
+ *   Author: Gregory Nutt <[email protected]>
+ *
+ * References:


are these references make sure that there will not be any licensing issues with this port?

Nuttx guys mention that it is an unrestricted license.
So I think there will be no license issues.

NilabhShant · 2019-03-26T14:30:52Z

@NilabhShant Could you check is it ok for patent?

@sunghan-chang As I back-ported from Nuttx and it is also a open source and those guys mention below reference

References:

Microsoft FAT documentation
Some good ideas were leveraged from the FAT implementation:
'Copyright (C) 2007, ChaN, all right reserved.'
which has an unrestricted license.

But I am not very sure about it ,Please give me your opinion.

satheesh-ks · 2019-03-27T05:13:25Z

os/fs/procfs/fs_procfs.c

@@ -210,6 +210,7 @@ const struct mountpt_operations procfs_operations = {
 	NULL,						/* sync */
 	procfs_dup,					/* dup */
 	NULL,						/* fstat */
+	NULL,


Mention funcptr variable in comment section as reference.
Like /* truncate */

Ok done, Please check

satheesh-ks · 2019-03-27T05:14:11Z

os/fs/smartfs/smartfs_smart.c

@@ -145,6 +145,7 @@ const struct mountpt_operations smartfs_operations = {
 	smartfs_sync,				/* sync */
 	smartfs_dup,				/* dup */
 	smartfs_fstat,				/* fstat */
+	NULL,


Mention funcptr variable in comment section as reference.
Like /* truncate */

seinfra · 2019-03-27T06:20:03Z

Target : [490c1425f316e2d8a2ea5a6a82cee985accddea6] - Code Rule Check (C++) OK.

seinfra · 2019-03-27T06:20:08Z

Target : [490c1425f316e2d8a2ea5a6a82cee985accddea6] - Code Rule Check OK.

yashwanth686007 · 2019-03-27T12:35:17Z

os/fs/fat/fs_fat32.h

+ */
+/* 446@0: Generally unused and zero; but may
+ * include IDM Boot Manager menu entry at 8@394 */
+#define PART_ENTRY(n)     (446+((n) << 4))	/* n = 0,1,2,3 */


Please correct coding guideline violations.

yashwanth686007 · 2019-03-27T12:35:54Z

os/fs/fat/fs_fat32.h

+ * Access to data in raw sector data */
+
+#define UBYTE_VAL(p,o)            (((uint8_t*)(p))[o])
+#define UBYTE_PTR(p,o)            &UBYTE_VAL(p,o)


Same as above.

Done, Please check

This patch adds support for vFAT file system on TizenRT back-ported from Nuttx Signed-off-by: Nilabh <[email protected]>

This patch adds requried support for vFAT file system in TizenRT. Back-ported from Nuttx Signed-off-by: Nilabh <[email protected]>

seinfra · 2019-03-28T06:37:54Z

Target : [9008bc0] - Code Rule Check (C++) OK.

seinfra · 2019-03-28T06:38:21Z

Target : [9008bc0] - Code Rule Check OK.

NilabhShant · 2019-04-08T06:54:40Z

@sunghan-chang please review and approve this PR.

seinfra · 2019-04-24T12:06:05Z

Target : [9008bc0] - Code Rule Check (C++) OK.

seinfra · 2019-04-24T12:19:00Z

Target : [9008bc0] - Code Rule Check (C++) OK.

sangam-swami · 2019-05-08T06:28:32Z

os/fs/fat/Kconfig

+# see kconfig-language at https://www.kernel.org/doc/Documentation/kbuild/kconfig-language.txt
+#
+
+config FS_FAT


yes only FAT32 support

seinfra · 2019-11-12T08:23:19Z

Target : [9008bc0] - Code Rule Check OK.

seinfra · 2019-11-12T08:26:18Z

Target : [9008bc0] - Code Rule Check (C++) OK.

tizen-build · 2020-04-10T03:10:54Z

Target : [9008bc0] - Code Rule Check OK.

tizen-build · 2023-03-21T02:17:14Z

Target : [9008bc0] - Code Rule Check OK.

sunghan-chang reviewed Mar 22, 2019

View reviewed changes

thapav reviewed Mar 22, 2019

View reviewed changes

NilabhShant force-pushed the STM32f4_Discovey_USB_Host branch from 0e0eea3 to fe684ac Compare March 22, 2019 10:38

NilabhShant force-pushed the STM32f4_Discovey_USB_Host branch from fe684ac to cea4041 Compare March 22, 2019 11:13

yashwanth686007 reviewed Mar 25, 2019

View reviewed changes

NilabhShant force-pushed the STM32f4_Discovey_USB_Host branch from cea4041 to 168c77a Compare March 26, 2019 06:03

sangam-swami reviewed Mar 26, 2019

View reviewed changes

satheesh-ks reviewed Mar 27, 2019

View reviewed changes

NilabhShant force-pushed the STM32f4_Discovey_USB_Host branch from 168c77a to 490c142 Compare March 27, 2019 06:08

yashwanth686007 reviewed Mar 27, 2019

View reviewed changes

Nilabh added 2 commits March 28, 2019 11:52

os/fs/fat: Add new file system support "vFAT"

f6ba29d

This patch adds support for vFAT file system on TizenRT back-ported from Nuttx Signed-off-by: Nilabh <[email protected]>

os/fs: Add functionality support for vFAT

9008bc0

This patch adds requried support for vFAT file system in TizenRT. Back-ported from Nuttx Signed-off-by: Nilabh <[email protected]>

NilabhShant force-pushed the STM32f4_Discovey_USB_Host branch from 490c142 to 9008bc0 Compare March 28, 2019 06:24

yashwanth686007 approved these changes Mar 29, 2019

View reviewed changes

satheesh-ks approved these changes Apr 3, 2019

View reviewed changes

thapav approved these changes Apr 3, 2019

View reviewed changes

sangam-swami approved these changes May 13, 2019

View reviewed changes


		/* Sanity checks */

		DEBUGASSERT(filep->f_priv == NULL && filep->f_inode != NULL);


		/* Synchronize the file buffers and disk content; update times */

		ret = fat_sync(filep);

os/fs : Add "vFAT" file system support in TizenRT #2827

Are you sure you want to change the base?

os/fs : Add "vFAT" file system support in TizenRT #2827

Conversation

NilabhShant commented Mar 22, 2019

seinfra commented Mar 22, 2019

seinfra commented Mar 22, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

NilabhShant Mar 22, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sunghan-chang commented Mar 22, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

seinfra commented Mar 22, 2019

seinfra commented Mar 22, 2019

seinfra commented Mar 22, 2019

seinfra commented Mar 22, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

NilabhShant Mar 28, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

NilabhShant Mar 26, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yashwanth686007 Mar 25, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

seinfra commented Mar 26, 2019

seinfra commented Mar 26, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

NilabhShant commented Mar 26, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

seinfra commented Mar 27, 2019

seinfra commented Mar 27, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

seinfra commented Mar 28, 2019

seinfra commented Mar 28, 2019

NilabhShant commented Apr 8, 2019

seinfra commented Apr 24, 2019

seinfra commented Apr 24, 2019

Choose a reason for hiding this comment

seinfra commented Nov 12, 2019

seinfra commented Nov 12, 2019

tizen-build commented Apr 10, 2020

tizen-build commented Mar 21, 2023

NilabhShant Mar 22, 2019 •

edited

Loading

sunghan-chang commented Mar 22, 2019 •

edited

Loading

NilabhShant Mar 28, 2019 •

edited

Loading

NilabhShant Mar 26, 2019 •

edited

Loading

yashwanth686007 Mar 25, 2019 •

edited

Loading

NilabhShant commented Mar 26, 2019 •

edited

Loading