Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[do not merge] network_utc: Refactor network utc #4163

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[do not merge] network_utc: Refactor network utc #4163

wants to merge 1 commit into from
+330 −934

Conversation

dr-venkman
Copy link
Contributor

Refactor network utc, with following in context:

  1. Remove functions no longer called
  2. Remove testcases no longer supported
  3. Include testcases for comprehensiveness
  4. Improve structure and general understanding of testcases.

@seinfra
Copy link

seinfra commented Jan 15, 2020

Target : [6685d4b2c8369d6ae1a47a7b2320ef00de4946a9] - Code Rule Check Result:
apps/examples/testcase/le_tc/network/tc_net_socket.c:627: ERROR: [BRC_M_FTN] open brace '{' following function declarations go on the next line
apps/examples/testcase/le_tc/network/tc_net_socket.c:638: ERROR: [BRC_M_FTN] open brace '{' following function declarations go on the next line
apps/examples/testcase/le_tc/network/tc_net_socket.c:646: ERROR: [BRC_M_FTN] open brace '{' following function declarations go on the next line
apps/examples/testcase/le_tc/network/tc_net_socket.c:657: ERROR: [BRC_M_FTN] open brace '{' following function declarations go on the next line
apps/examples/testcase/le_tc/network/tc_net_socket.c:670: ERROR: [BRC_M_FTN] open brace '{' following function declarations go on the next line
apps/examples/testcase/le_tc/network/tc_net_socket.c:681: ERROR: [BRC_M_FTN] open brace '{' following function declarations go on the next line
apps/examples/testcase/le_tc/network/tc_net_socket.c:695: ERROR: [BRC_M_FTN] open brace '{' following function declarations go on the next line
apps/examples/testcase/le_tc/network/tc_net_socket.c:700: ERROR: [BRC_M_FTN] open brace '{' following function declarations go on the next line
apps/examples/testcase/le_tc/network/tc_net_socket.c:705: ERROR: [BRC_M_FTN] open brace '{' following function declarations go on the next line
apps/examples/testcase/le_tc/network/tc_net_socket.c:710: ERROR: [BRC_M_FTN] open brace '{' following function declarations go on the next line

@seinfra
Copy link

seinfra commented Jan 15, 2020

Target : [6685d4b2c8369d6ae1a47a7b2320ef00de4946a9] - Code Rule Check (C++) OK.

@dr-venkman dr-venkman force-pushed the refactor_network_utc branch from 6685d4b to 05cc55c Compare January 15, 2020 09:34
@seinfra
Copy link

seinfra commented Jan 15, 2020

Target : [05cc55cd55876b76c986231ce2633e481bc08bb4] - Code Rule Check (C++) OK.

@seinfra
Copy link

seinfra commented Jan 15, 2020

Target : [05cc55cd55876b76c986231ce2633e481bc08bb4] - Code Rule Check Result:
apps/examples/testcase/le_tc/network/tc_net_socket.c:627: ERROR: [BRC_M_FTN] open brace '{' following function declarations go on the next line
apps/examples/testcase/le_tc/network/tc_net_socket.c:638: ERROR: [BRC_M_FTN] open brace '{' following function declarations go on the next line
apps/examples/testcase/le_tc/network/tc_net_socket.c:646: ERROR: [BRC_M_FTN] open brace '{' following function declarations go on the next line
apps/examples/testcase/le_tc/network/tc_net_socket.c:657: ERROR: [BRC_M_FTN] open brace '{' following function declarations go on the next line
apps/examples/testcase/le_tc/network/tc_net_socket.c:670: ERROR: [BRC_M_FTN] open brace '{' following function declarations go on the next line
apps/examples/testcase/le_tc/network/tc_net_socket.c:681: ERROR: [BRC_M_FTN] open brace '{' following function declarations go on the next line
apps/examples/testcase/le_tc/network/tc_net_socket.c:695: ERROR: [BRC_M_FTN] open brace '{' following function declarations go on the next line
apps/examples/testcase/le_tc/network/tc_net_socket.c:700: ERROR: [BRC_M_FTN] open brace '{' following function declarations go on the next line
apps/examples/testcase/le_tc/network/tc_net_socket.c:705: ERROR: [BRC_M_FTN] open brace '{' following function declarations go on the next line
apps/examples/testcase/le_tc/network/tc_net_socket.c:710: ERROR: [BRC_M_FTN] open brace '{' following function declarations go on the next line

@dr-venkman dr-venkman force-pushed the refactor_network_utc branch from 05cc55c to 47a67a4 Compare January 15, 2020 09:39
@seinfra
Copy link

seinfra commented Jan 15, 2020

Target : [47a67a4d4f1eeb7e5980e3434302b8325955c928] - Code Rule Check (C++) OK.

@seinfra
Copy link

seinfra commented Jan 15, 2020

Target : [47a67a4d4f1eeb7e5980e3434302b8325955c928] - Code Rule Check OK.

@dr-venkman dr-venkman requested a review from pillip8282 January 15, 2020 09:52
pillip8282
pillip8282 previously approved these changes Jan 16, 2020
View reviewed changes
Copy link
Contributor

@pillip8282 pillip8282 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's easier to understand compared to previous one.
looks good to me

@dr-venkman dr-venkman force-pushed the refactor_network_utc branch from 47a67a4 to 8960334 Compare January 20, 2020 02:59
@seinfra
Copy link

seinfra commented Jan 20, 2020

Target : [8960334e494b4e2162649feb3ed6b87fce78aaa9] - Code Rule Check (C++) OK.

@seinfra
Copy link

seinfra commented Jan 20, 2020

Target : [8960334e494b4e2162649feb3ed6b87fce78aaa9] - Code Rule Check Result:
apps/examples/testcase/le_tc/network/tc_net_setsockopt.c:125: ERROR: [SPC_M_OPR] spaces required around that '=' (ctx:VxV)
apps/examples/testcase/le_tc/network/tc_net_setsockopt.c:522: ERROR: [IDT_M_TAB] please, no spaces at the start of a line
apps/examples/testcase/le_tc/network/tc_net_setsockopt.c:524: ERROR: [IDT_M_TAB] please, no spaces at the start of a line
apps/examples/testcase/le_tc/network/tc_net_setsockopt.c:525: ERROR: [IDT_M_TAB] please, no spaces at the start of a line
apps/examples/testcase/le_tc/network/tc_net_setsockopt.c:526: ERROR: [IDT_M_TAB] please, no spaces at the start of a line
apps/examples/testcase/le_tc/network/tc_net_setsockopt.c:562: ERROR: [SPC_M_OPR] space required after that ',' (ctx:VxV)

@dr-venkman dr-venkman force-pushed the refactor_network_utc branch from 8960334 to 7599e1f Compare January 20, 2020 03:13
@seinfra
Copy link

seinfra commented Jan 20, 2020

Target : [7599e1f4ebffb994d146e687f71302d1a85639a1] - Code Rule Check Result:
apps/examples/testcase/le_tc/network/tc_net_setsockopt.c:125: ERROR: [SPC_M_OPR] spaces required around that '=' (ctx:VxV)
apps/examples/testcase/le_tc/network/tc_net_setsockopt.c:522: ERROR: [IDT_M_TAB] please, no spaces at the start of a line
apps/examples/testcase/le_tc/network/tc_net_setsockopt.c:524: ERROR: [IDT_M_TAB] please, no spaces at the start of a line
apps/examples/testcase/le_tc/network/tc_net_setsockopt.c:525: ERROR: [IDT_M_TAB] please, no spaces at the start of a line
apps/examples/testcase/le_tc/network/tc_net_setsockopt.c:526: ERROR: [IDT_M_TAB] please, no spaces at the start of a line
apps/examples/testcase/le_tc/network/tc_net_setsockopt.c:562: ERROR: [SPC_M_OPR] space required after that ',' (ctx:VxV)

@seinfra
Copy link

seinfra commented Jan 20, 2020

Target : [7599e1f4ebffb994d146e687f71302d1a85639a1] - Code Rule Check (C++) OK.

@dr-venkman dr-venkman force-pushed the refactor_network_utc branch from 7599e1f to 15f66cc Compare January 20, 2020 03:18
@seinfra
Copy link

seinfra commented Jan 20, 2020

Target : [15f66cc] - Code Rule Check OK.

@seinfra
Copy link

seinfra commented Jan 20, 2020

Target : [15f66cc] - Code Rule Check (C++) OK.

@dr-venkman
[do not merge] network_utc: Refactor network utc
15f66cc 
Refactor network utc, with following in context:

1. Remove functions no longer called
2. Remove testcases no longer supported
3. Include testcases for comprehensiveness
4. Improve structure and general understanding of testcases.
dr-venkman
dr-venkman commented Jan 20, 2020
View reviewed changes
Copy link
Contributor Author

@dr-venkman dr-venkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly review, thank you.

sunghan-chang
sunghan-chang requested changes Jan 28, 2020
View reviewed changes
apps/examples/testcase/le_tc/network/tc_net_setsockopt.c
tc_net_setsockopt_multicast_tcp_nodelay_p(fd);
}

static void tc_net_setsockopt_n(int fd)
Copy link
Contributor

@sunghan-chang sunghan-chang Jan 28, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every tc should include TC_ASSERT_XX macro. These functions are named tc_<module-name>_<submodule>_p/n but they don't include the macro. Then, you should use the postfix as _main.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the naming rule we should follow in testcase.

jsdosa
jsdosa approved these changes Mar 19, 2020
View reviewed changes
Copy link
Contributor

@jsdosa jsdosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@tizen-build
Copy link

Target : [15f66cc] - Code Rule Check OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunghan-chang sunghan-chang sunghan-chang requested changes

@jsdosa jsdosa jsdosa approved these changes

@pillip8282 pillip8282 pillip8282 left review comments

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dr-venkman @seinfra @tizen-build @pillip8282 @sunghan-chang @jsdosa