ai-soc/ndp120: implement packages loding to NDP120 in chunks #6561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to reduce the memory usage during loading of synpkgs, implement package loading in chunks Signed-off-by: Abhishek Akkabathula <[email protected]>
Taejun-Kwon
previously approved these changes
Dec 6, 2024
Incase we use recorder without Keyword detection, skip the start point correction we do for Keyword detection case. Signed-off-by: Abhishek Akkabathula <[email protected]>
Taejun-Kwon
approved these changes
Dec 6, 2024
r-prabu
reviewed
Dec 6, 2024
| @@ -78,6 +78,7 @@ struct ndp120_dev_s { | |||
| uint32_t extract_size; | |||
| bool extclk_inuse; | |||
| volatile bool alive; | |||
| bool keyword_correction; | |||
There was a problem hiding this comment.
on what basis the keyword_correction is enabled and disabled? Do we need to provide this control also to the application?
| @@ -446,6 +446,7 @@ static int load_synpkg(struct syntiant_ndp_device_s *ndp, const char *p) | |||
| int s = 0; | |||
| int pfd; | |||
| int rl; | |||
| int chunk_size = 1024; | |||
There was a problem hiding this comment.
Is it better to provide this chunk size with config?
kishore-sn
reviewed
Dec 6, 2024
| @@ -446,6 +446,7 @@ static int load_synpkg(struct syntiant_ndp_device_s *ndp, const char *p) | |||
| int s = 0; | |||
| int pfd; | |||
| int rl; | |||
| int chunk_size = 1024; | |||
There was a problem hiding this comment.
Let us not hardcode this. Let us atleast use a #define instead.
| s = syntiant_ndp_extract_data(dev->ndp, SYNTIANT_NDP_EXTRACT_TYPE_INPUT, | ||
| if (dev->keyword_correction) { | ||
| /* we need not do this if this is resume case, we only need to do it if its recorder start case after keyword detection */ | ||
| s = syntiant_ndp_extract_data(dev->ndp, SYNTIANT_NDP_EXTRACT_TYPE_INPUT, | ||
| SYNTIANT_NDP_EXTRACT_FROM_MATCH, NULL, |
|
Please change the PR title from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to reduce the memory usage during loading of synpkgs, implement package loading in chunks