INT-648: Add patient BSN to Tasks created through Frontend #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reinkrul
requested review from
JorisHeadease and
dwelman
and removed request for
JorisHeadease
dwelman
reviewed
Mar 3, 2025
frontend/lib/fhirUtils.ts
Outdated
| const patientReference : Reference = { | ||
| type: "Patient", | ||
| reference: "urn:uuid:patient", | ||
| identifier: patient.identifier?.filter((identifier) => identifier.system === BSN_SYSTEM)[0]! |
There was a problem hiding this comment.
This could result in an unhandled error, could we wrap this in a try catch?
There was a problem hiding this comment.
And it probably shouldn't be hardcoded support BSN only. So maybe we just take the first identifier or something... Or configure a list of preferred patient identifier systems.
There was a problem hiding this comment.
We want to be international and BSN is very Dutchy.
There was a problem hiding this comment.
Made it configurable, now defaults to BSN.
Note tht the line you initially pointed out can't fail, because on initialization it checks whether it can resolve the patient identifier.
dwelman
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.