Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INT-611: Introduce extendable messaging service #460

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

reinkrul
Copy link
Contributor

@reinkrul reinkrul commented Mar 4, 2025

This introduces a messaging service, which lays the groundwork for reliable event and FHIR subscription notification handling. It can be extended with more topics/queues to be published on and message receivers. Additional changes:

  • Mostly reimplements the existing Azure Service Bus integration for delivery of the enrolment bundle (renamed to "task filler/task accepted bundle" since Task workflows aren't just for enrolments).
  • Removes the "debug" (write messages to disk) feature of the ServiceBus integration, since it was used during development, but not afterwards. Use unit tests, or the HTTP messaging endpoint instead.
  • Removes the "ping" (sends a text message "ping" to a topic on startup) feature of the ServiceBus integration, since it was used during development, but will cause increased ops-load on test/acc/production environments (since it's a message that most probably can't be processed, it'll end up in the DLQ).
  • Moved the delivery of enrolment bundles over HTTP (a.k.a. "demo client") to a separate HTTP message broker implementation.
  • Moved configuration of message broker from CPC to ORCA root, since it'll also be used by CPS.
  • Removed the Azure Service Bus setup in the local deployment, introduced an integration test instead. Reason: it starts slowly and adds additional overhead to the (already) heavy-weight local-dev deployment. We'll support an in-memory broker very soon, which is to be preferred for local-dev deployment.
  • Improved documentation

@reinkrul reinkrul requested review from JorisHeadease, dwelman, rolandgroen and jdksloan and removed request for JorisHeadease March 4, 2025 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant