[core] issue knowm#2397 - NPE for Trade hash

SaschaZ · Mar 11, 2018 · 00cdeeb · 00cdeeb
1 parent aac1405
commit 00cdeeb
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/xchange-core/src/main/java/org/knowm/xchange/dto/marketdata/Trade.java b/xchange-core/src/main/java/org/knowm/xchange/dto/marketdata/Trade.java
@@ -3,6 +3,7 @@
 import java.io.Serializable;
 import java.math.BigDecimal;
 import java.util.Date;
+import java.util.Objects;
 
 import org.knowm.xchange.currency.CurrencyPair;
 import org.knowm.xchange.dto.Order.OrderType;
@@ -109,7 +110,7 @@ public boolean equals(Object o) {
   @Override
   public int hashCode() {
 
-    return id.hashCode();
+    return Objects.hashCode(id);
   }
 
   @Override

diff --git a/xchange-kucoin/src/main/java/org/knowm/xchange/kucoin/dto/marketdata/KucoinDealOrder.java b/xchange-kucoin/src/main/java/org/knowm/xchange/kucoin/dto/marketdata/KucoinDealOrder.java
@@ -16,7 +16,7 @@ public class KucoinDealOrder {
   private BigDecimal volume;
 
   public KucoinDealOrder(Long timestamp, KucoinOrderType orderType, BigDecimal price, BigDecimal amount, BigDecimal volume) {
-    super();
+
     this.timestamp = timestamp;
     this.orderType = orderType;
     this.price = price;