Skip to content

Commit

Permalink
[FLINK-4219] [scripts] Quote PDSH opts in start-cluster.sh
Browse files Browse the repository at this point in the history
This prevents word splitting if the user configures multiple SSH
options.

This closes apache#2253.
  • Loading branch information
greghogan authored and uce committed Aug 5, 2016
1 parent 245f02b commit 6590a4c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion flink-dist/src/main/flink-bin/bin/start-cluster.sh
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,6 @@ if [[ $? -ne 0 ]]; then
ssh -n $FLINK_SSH_OPTS $slave -- "nohup /bin/bash -l \"${FLINK_BIN_DIR}/taskmanager.sh\" start &"
done
else
PDSH_SSH_ARGS="" PDSH_SSH_ARGS_APPEND=$FLINK_SSH_OPTS pdsh -w $(IFS=, ; echo "${SLAVES[*]}") \
PDSH_SSH_ARGS="" PDSH_SSH_ARGS_APPEND="${FLINK_SSH_OPTS}" pdsh -w $(IFS=, ; echo "${SLAVES[*]}") \
"nohup /bin/bash -l \"${FLINK_BIN_DIR}/taskmanager.sh\" start"
fi

0 comments on commit 6590a4c

Please sign in to comment.