Skip to content

Commit

Permalink
[FLINK-3437] [web-dashboard] Fix UI router state for job plan
Browse files Browse the repository at this point in the history
Transitive dependency EvEmitter updated to 1.0.2

This closes apache#1661
  • Loading branch information
greghogan authored and rmetzger committed Feb 26, 2016
1 parent db6fda6 commit ee76fc4
Show file tree
Hide file tree
Showing 5 changed files with 835 additions and 406 deletions.
2 changes: 1 addition & 1 deletion flink-runtime-web/web-dashboard/app/partials/jobs/job.jade
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ nav.navbar.navbar-default.navbar-fixed-top.navbar-main(ng-if="job")
nav.navbar.navbar-default.navbar-fixed-top.navbar-main-additional(ng-if="job")
ul.nav.nav-tabs
li(ui-sref-active='active')
a(ui-sref=".plan.subtasks") Plan
a(ui-sref=".plan") Plan

//- li(ui-sref-active='active' ng-if="job['end-time'] > -1")
li(ui-sref-active='active')
Expand Down
10 changes: 9 additions & 1 deletion flink-runtime-web/web-dashboard/app/scripts/index.coffee
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,14 @@ angular.module('flinkApp', ['ui.router', 'angularMoment'])

# --------------------------------------

.run ($rootScope, $state) ->
$rootScope.$on '$stateChangeStart', (event, toState, toParams, fromState) ->
if toState.redirectTo
event.preventDefault()
$state.go toState.redirectTo, toParams

# --------------------------------------

.config ($stateProvider, $urlRouterProvider) ->
$stateProvider.state "overview",
url: "/overview"
Expand Down Expand Up @@ -86,7 +94,7 @@ angular.module('flinkApp', ['ui.router', 'angularMoment'])

.state "single-job.plan",
url: ""
abstract: true
redirectTo: "single-job.plan.subtasks"
views:
details:
templateUrl: "partials/jobs/job.plan.html"
Expand Down
89 changes: 48 additions & 41 deletions flink-runtime-web/web-dashboard/web/js/index.js

Large diffs are not rendered by default.

Loading

0 comments on commit ee76fc4

Please sign in to comment.