Skip to content

Commit

Permalink
move coverage to separate job
Browse files Browse the repository at this point in the history
  • Loading branch information
donmccurdy committed Apr 13, 2022
1 parent be90afa commit 5fea9d0
Show file tree
Hide file tree
Showing 4 changed files with 27 additions and 38 deletions.
14 changes: 9 additions & 5 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,13 @@ jobs:
- run: yarn dist
- run: yarn test
- run: yarn lint

# Coverage.
- run: yarn coverage:report
- uses: codecov/codecov-action@v2
with:
files: ./nyc_output/coverage.lcov

coverage:
runs-on: macos-latest
needs: build
steps:
- uses: actions/checkout@v3
- uses: codecov/codecov-action@v2
with:
files: .coverage.lcov
27 changes: 17 additions & 10 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,20 +1,27 @@
# yarn
node_modules
.coveralls.yml
.yarn
.yarnrc

# debug
*.log
.now
.nyc_output
.rpt2_cache

# editor
.vscode

# test data
**/out/*
!**/out/.gitkeep

# build artifacts
packages/**/dist/*
packages/**/.rts2_cache_cjs
packages/**/.rts2_cache_es
packages/**/.rts2_cache_umd
packages/**/.rts2_cache_modern
docs/dist/**
coverage
packages/**/.rts2*

# documentation
.vercel
docs/dist/**

# coverage
.nyc_output
coverage
.coverage.lcov
3 changes: 1 addition & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"clean:deps": "rm -rf packages/*/node_modules/**",
"test": "ts-node node_modules/tape/bin/tape packages/*/test/{*/,}*.test.ts | tap-spec",
"coverage": "nyc --reporter=lcov --reporter=text ts-node node_modules/tape/bin/tape packages/*/test/{*/,}*.test.ts",
"coverage:report": "nyc report --reporter=text-lcov > .nyc_output/coverage.lcov",
"coverage:report": "nyc report --reporter=text-lcov > .coverage.lcov",
"lint": "eslint \"packages/*/{src,test}/**/*.ts\"",
"validate": "scripts/validate.js",
"preversion": "yarn run test",
Expand All @@ -36,7 +36,6 @@
"@typescript-eslint/parser": "5.18.0",
"canvas": "2.9.1",
"concurrently": "7.1.0",
"coveralls": "3.1.1",
"draco3dgltf": "1.5.2",
"eslint": "8.13.0",
"eslint-config-prettier": "8.5.0",
Expand Down
21 changes: 0 additions & 21 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -3226,17 +3226,6 @@ cosmiconfig@^7.0.0:
path-type "^4.0.0"
yaml "^1.10.0"

[email protected]:
version "3.1.1"
resolved "https://registry.yarnpkg.com/coveralls/-/coveralls-3.1.1.tgz#f5d4431d8b5ae69c5079c8f8ca00d64ac77cf081"
integrity sha512-+dxnG2NHncSD1NrqbSM3dn/lE57O6Qf/koe9+I7c+wzkqRmEvcp0kgJdxKInzYzkICKkFMZsX3Vct3++tsF9ww==
dependencies:
js-yaml "^3.13.1"
lcov-parse "^1.0.0"
log-driver "^1.2.7"
minimist "^1.2.5"
request "^2.88.2"

create-require@^1.1.0:
version "1.1.1"
resolved "https://registry.yarnpkg.com/create-require/-/create-require-1.1.1.tgz#c1d7e8f1e5f6cfc9ff65f9cd352d37348756c333"
Expand Down Expand Up @@ -5584,11 +5573,6 @@ language-tags@^1.0.5:
dependencies:
language-subtag-registry "~0.3.2"

lcov-parse@^1.0.0:
version "1.0.0"
resolved "https://registry.yarnpkg.com/lcov-parse/-/lcov-parse-1.0.0.tgz#eb0d46b54111ebc561acb4c408ef9363bdc8f7e0"
integrity sha1-6w1GtUER68VhrLTECO+TY73I9+A=

[email protected]:
version "4.0.0"
resolved "https://registry.yarnpkg.com/lerna/-/lerna-4.0.0.tgz#b139d685d50ea0ca1be87713a7c2f44a5b678e9e"
Expand Down Expand Up @@ -5767,11 +5751,6 @@ lodash@^4.17.21, lodash@^4.7.0:
resolved "https://registry.yarnpkg.com/lodash/-/lodash-4.17.21.tgz#679591c564c3bffaae8454cf0b3df370c3d6911c"
integrity sha512-v2kDEe57lecTulaDIuNTPy3Ry4gLGJ6Z1O3vE1krgXZNrsQ+LFTGHVxVjcXPs17LhbZVGedAJv8XZ1tvj5FvSg==

log-driver@^1.2.7:
version "1.2.7"
resolved "https://registry.yarnpkg.com/log-driver/-/log-driver-1.2.7.tgz#63b95021f0702fedfa2c9bb0a24e7797d71871d8"
integrity sha512-U7KCmLdqsGHBLeWqYlFA0V0Sl6P08EE1ZrmA9cxjUE0WVqT9qnyVDPz1kzpFEP0jdJuFnasWIfSd7fsaNXkpbg==

log-symbols@^4.1.0:
version "4.1.0"
resolved "https://registry.yarnpkg.com/log-symbols/-/log-symbols-4.1.0.tgz#3fbdbb95b4683ac9fc785111e792e558d4abd503"
Expand Down

0 comments on commit 5fea9d0

Please sign in to comment.