fixed logic bug around tps computation

Scliin1 · May 3, 2023 · 508ca19 · 508ca19
1 parent 2360c0a
commit 508ca19
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/quaistats/quaistats.go b/quaistats/quaistats.go
@@ -632,9 +632,9 @@ func (s *Service) computeTps(block *types.Block) (uint64, error) {
 
 	var blockTps uint64
 	if parentTps == c_uintMaxValue {
-		blockTps = ((c_alpha-1)*parentTps + instantTps) / c_alpha
-	} else {
 		blockTps = instantTps
+	} else {
+		blockTps = ((c_alpha-1)*parentTps + instantTps) / c_alpha
 	}
 
 	s.tpsLookupCache.Add(block.Hash(), blockCacheDto{
@@ -706,7 +706,7 @@ func (s *Service) assembleBlockStats(block *types.Block) *blockStats {
 		ChainID:       s.chainID.Uint64(),
 	}
 
-	if tps, err := s.computeTps(block); err != nil {
+	if tps, err := s.computeTps(block); err == nil {
 		ret.Tps = tps
 	} else {
 		log.Error("error computing tps", "error", err.Error())